Repository navigation
EDGEML-15209: relax xclbin m_length check to tolerate legacy files - #10135
Merged
Merged
Conversation
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Accept xclbins where m_header.m_length does not exactly match the buffer size; only reject when the buffer is smaller than m_length declares, which would risk out-of-bounds access. Downstream bounds checks (section header array and per-section offset/size) use the actual buffer size and remain the true safety net. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Soren Soe <2106410+stsoe@users.noreply.github.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Accept xclbins where m_header.m_length does not exactly match the buffer size; only reject when the buffer is smaller than m_length declares, which would risk out-of-bounds access. Downstream bounds checks (section header array and per-section offset/size) use the actual buffer size and remain the true safety net.