Create directory fido-mds-cache in runtime phase - #513
Merged
Merged
Conversation
Before this, `./gradlew clean integrationTest` fails because the `fido-mds-cache` directory does not exist. This is because the `mkdirs()` statement in the `integrationTest` task configuration executes in the configuration phase, while the `clean` task executes in the runtime phase and deletes the directory after the `mkdirs()` statement has created it (or it already existed). Putting the `mkdirs()` statement in a separate prerequisite task ensures that it executes after the `clean` task but before the `integrationTest` task (unless the user explicitly runs `./gradlew makeMdsCacheDir clean integrationTest`, but that's on them in that case).
Test Results 288 files 288 suites 7m 16s ⏱️ Results for commit d0f6c0f. |
fdennis
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this,
./gradlew clean integrationTestfails because thefido-mds-cachedirectory does not exist. This is because themkdirs()statement in theintegrationTesttask configuration executes in the configuration phase, while thecleantask executes in the runtime phase and deletes the directory after themkdirs()statement has created it (or it already existed). Putting themkdirs()statement in a separate prerequisite task ensures that it executes after thecleantask but before theintegrationTesttask (unless the user explicitly runs./gradlew makeMdsCacheDir clean integrationTest, but that's on them in that case).