Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the CTAPHID INIT handshake raises after
open_connection()succeeds,open_device()andCtapHidDevice.list_devices()never return a device that the caller can close. The connection remains open. This can happen during a disconnect or a failed initial exchange.Route both factories through a small classmethod that closes the connection on construction failure and re-raises the original exception. A cleanup error does not replace the initialization error. Successful construction still transfers ownership to the returned device, and enumeration preserves
clsconstruction. The public constructor's handling of caller-provided connections is unchanged.Validation on macOS / Python 3.11:
pytest tests --ignore=tests/device -q: 160 passed.git diff --check: passed for the changed files.The new tests mock HID I/O and do not access physical authenticators. Native hardware/other-platform execution has not been tested for this patch.