Repository navigation
D-121: draw the Vendor mine as a ring - #228
Merged
Merged
Conversation
The renderer test draws an arming mine and an armed mine. The fill is clear, the stroke is white 0.92 at alpha 0.95, the widths are 2 and 4, and the path is the authored radius.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
T1060. The Victorian Vendor mine is drawn as a clear-filled ring. One light neutral stroke, white 0.92 at alpha 0.95, weight 2 while arming and 4 once armed. The path stays the authoritative radius. Arm 30, life 240, radius 42, damage 12, and the cap of two are unchanged. No caption and no asset id.
Pins
b1ed874e1e8eb0e61b2174b9093201e9a61e1a4b(SS-specs #91). Ruleset staysss-rules-014, contentcivic-seam-content-009, arenacivic-seam-arena-004, replayruntime-kernel-001. Catalog entries are unchanged; onlyspecificationCommitmoves.MineRingPresentationTestsdraws one arming mine and one armed mine and checks the fill, the stroke, both widths, and the authored radius.Cut from current main
1e4d3fc. Runtime #167 stays onfeat/d120-shell-copy.Test plan
MineRingPresentationTestspassed