Skip to content

[Fix] Restore subtask approvals when users return to tasks - #1320

Draft
zoomote[bot] wants to merge 2 commits into
mainfrom
fix/subtask-approval-recovery-3jjp9x3600fnq
Draft

[Fix] Restore subtask approvals when users return to tasks#1320
zoomote[bot] wants to merge 2 commits into
mainfrom
fix/subtask-approval-recovery-3jjp9x3600fnq

Conversation

@zoomote

@zoomote zoomote Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

​Created by Roomote. Follow up by mentioning @roomote, in the web UI, or in Discord.

What changed

  • Persist validated new_task and finishTask actions while they await approval, then restore the executable action instead of a generic resume prompt.
  • Give queued lifecycle feedback priority over auto-approval and keep it claimed until its history row is saved successfully.
  • Reject stale restored actions before lifecycle side effects and at atomic commit boundaries.
  • Add direct branch coverage for pending-action replay, queue claims and retries, provider metadata transitions, native approval feedback, and history schemas, alongside the VS Code e2e regression.

Why this change was made

Issue #1223 showed that leaving and returning to subtask workflows replaced approval controls with Continue or Start New Task. It also exposed a race where auto-approved completion could discard queued feedback. This work is tracked under #355 and coordinates with the existing task-lifecycle roadmap.

Impact

Users can return to pending subtask creation or completion approvals and continue the intended workflow. Queued feedback is retained and processed before automatic completion, including across transient history-write failures.

Related PRs

Closes #1223

@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Subtask shows “Start new task” / “Continue” instead of approve/confirm after leave-and-return; queued message lost on attempt_complete

1 participant