chore: bump io.github.ascopes:protobuf-maven-plugin from 4.1.2 to 5.1.4

[dependabot]

Bumps io.github.ascopes:protobuf-maven-plugin from 4.1.2 to 5.1.4, along with the required configuration updates for the v5.x API and a new CI workflow to verify gRPC generation.

Plugin configuration changes (spec-grpc/pom.xml)

The v5.x release removed deprecated legacy configuration elements. The following changes were made:

• <binaryMavenPlugins>/<binaryMavenPlugin> replaced with <plugins>/<plugin kind="binary-maven">
• <protoc>${protobuf-java.version}</protoc> updated to <protoc kind="binary-maven"><version>${protobuf-java.version}</version></protoc>

compat-0.3/spec-grpc uses a different plugin (org.xolstice.maven.plugins:protobuf-maven-plugin) and requires no changes.

New CI workflow (.github/workflows/verify-grpc-generation.yml)

Since protobuf generation is an offline activity and not part of the regular build, a new workflow is added to verify the generation step continues to work. It runs:

mvn install -B -DskipTests -pl spec-grpc,compat-0.3/spec-grpc -am -Dskip.protobuf.generate=false -Pproto-compile

You can trigger a rebase of this PR by commenting @dependabot rebase.

---

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

[kabir]

@ehsavoie is this safe? I guess our CI doesn't generate the protobuf, since we do this on demand so I'm a bit hesitant

[ehsavoie]

No this is not going to work:

<configuration>
  <binaryMavenPlugins>
    <binaryMavenPlugin>...</binaryMavenPlugin>
    <binaryMavenPlugin>...</binaryMavenPlugin>
  </binaryMavenPlugins>

should be replaces by

<configuration>
  <plugins>
    <plugin kind="binary-maven">...</plugin>
    <plugin kind="binary-maven">...</plugin>
    <plugin kind="jvm-maven">...</plugin>
    <plugin kind="path">...</plugin>
    <plugin kind="url">...</plugin>
    ...
  </plugins>
</configuration>

[kabir]

@copilot As seen in the previous comment #884 (comment) this naive upgrade is not going to work. Note we do not run the protobuf generation in spec-grpc and compat-0.3/spec-grpc on every build. Rather it is an offline activity..
Maybe we should have another GitHub Action verifying that protobuf generation is working. I think it can just do a mvn install -DskipTests -pl spec-grpc,compat-0.3/spec-grpc -am along with anything needed to do the grpc generation

[Copilot]

@copilot As seen in the previous comment #884 (comment) this naive upgrade is not going to work. Note we do not run the protobuf generation in ...

Added a new workflow .github/workflows/verify-grpc-generation.yml (commit chore: add GitHub Action to verify protobuf gRPC generation) that runs:

mvn install -B -DskipTests -pl spec-grpc,compat-0.3/spec-grpc -am -Dskip.protobuf.generate=false -Pproto-compile

The -Dskip.protobuf.generate=false overrides the default (which skips generation in spec-grpc) and -Pproto-compile activates the generation profile in compat-0.3/spec-grpc.

[kabir]

@copilot

@copilot As seen in the previous comment #884 (comment) this naive upgrade is not going to work. Note we do not run the protobuf generation in ...

Added a new workflow .github/workflows/verify-grpc-generation.yml (commit chore: add GitHub Action to verify protobuf gRPC generation) that runs:

mvn install -B -DskipTests -pl spec-grpc,compat-0.3/spec-grpc -am -Dskip.protobuf.generate=false -Pproto-compile

The -Dskip.protobuf.generate=false overrides the default (which skips generation in spec-grpc) and -Pproto-compile activates the generation profile in compat-0.3/spec-grpc.
But it sounds from the comment I mentioned earlier that we also need to reconfigure the use of the plugin in the poms?

[Copilot]

@copilot

@copilot As seen in the previous comment #884 (comment) this naive upgrade is not going to work. Note we do no...

Updated spec-grpc/pom.xml in commit fix: update protobuf-maven-plugin configuration for v5.x API changes with the two breaking changes from v4→v5:

1. <binaryMavenPlugins>/<binaryMavenPlugin> → <plugins>/<plugin kind="binary-maven">
2. <protoc>${protobuf-java.version}</protoc> → <protoc kind="binary-maven"><version>${protobuf-java.version}</version></protoc>

Note: compat-0.3/spec-grpc uses the org.xolstice.maven.plugins:protobuf-maven-plugin (a different plugin, version pinned via ${protobuf-maven-plugin.version}=0.6.1), so no changes are needed there.

[dependabot]

A newer version of io.github.ascopes:protobuf-maven-plugin exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.