Add valid version improver - #1138
Merged
Merged
Conversation
6 tasks done
TG1999
force-pushed
the
add_valid_versions_improver
branch
from
February 27, 2023 17:11
3603423 to
50bfc60
Compare
TG1999
marked this pull request as draft
February 27, 2023 17:12
TG1999
force-pushed
the
add_valid_versions_improver
branch
2 times, most recently
from
March 1, 2023 10:21
a3c1bea to
f940384
Compare
TG1999
marked this pull request as ready for review
March 1, 2023 10:52
pombredanne
reviewed
Mar 1, 2023
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
A philosophical question: should we rather try to keep all the code about a given data source in one module? e.g., keep everything about Apache HTTPD in a single script? I feel that this may be more effective than scattered code in one place for the importer and another for an improver? This is not critical as this can be improved afterwards of course.
TG1999
commented
Mar 17, 2023
TG1999
left a comment
TG1999
left a comment
Contributor
Author
There was a problem hiding this comment.
Some review nits....
|
|
||
| class ApacheHTTPDImprover(ValidVersionImprover): | ||
| importer = ApacheHTTPDImporter | ||
| ignorable_versions = APACHE_HTTPD_IGNORABLE_TAGS |
|
|
||
| class GitHubBasicImprover(ValidVersionImprover): | ||
| importer = GitHubAPIImporter | ||
| ignorable_versions = GITHUB_IGNORABLE_VERSIONS |
pombredanne
approved these changes
Mar 17, 2023
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
LGTM.... please merge with your planned updates!
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
force-pushed
the
add_valid_versions_improver
branch
from
March 21, 2023 11:06
3d057d4 to
3134cc5
Compare
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.