Repository navigation
Make util::tuple::rank<N> a flat inheritance chain. - #1935
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_1009274957
branch
from
November 3, 2026 10:25
163f307 to
fe5e5df
Compare
`rank<N>` used to expand to `kMaxRank + 1 - N` nested `internal_rank::wrapper<>` class templates. That nesting existed only so `rank<N, T>` could order class template partial specializations. Every function that takes a `rank<N>` parameter carried that nesting in its symbol name: up to ~300 B mangled and ~1.4 KB demangled per parameter. The same nesting showed up as one DWARF type per nesting level. Overload resolution behaves the same: `rank<N>` still converts to `rank<M>` for every `M >= N`, and the conversion is better the smaller `M` is. The mangled name is now a short constant size. The 2-argument `rank<N, T>` class-specialization form is removed; it has no remaining users. PiperOrigin-RevId: 1012859579
copybara-service
Bot
force-pushed
the
test_1009274957
branch
from
November 3, 2026 10:58
fe5e5df to
7ae1724
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
util::tuple::rank<N>a flat inheritance chain.rank<N>used to expand tokMaxRank + 1 - Nnestedinternal_rank::wrapper<>class templates. That nesting existed only so
rank<N, T>could order classtemplate partial specializations. Every function that takes a
rank<N>parameter carried that nesting in its symbol name: up to ~300 B mangled and
~1.4 KB demangled per parameter. The same nesting showed up as one DWARF type
per nesting level.
Overload resolution behaves the same:
rank<N>still converts to
rank<M>for everyM >= N, and the conversion is betterthe smaller
Mis. The mangled name is now a short constant size.The 2-argument
rank<N, T>class-specialization form is removed; it has noremaining users.