fix: isolate LiteLLM embedding credential from ambient OpenAI key - #279
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow the OpenAI-compatible smem embedder to use
SURREAL_MEMORY_EMBEDDING_API_KEYindependently of an unrelated ambientOPENAI_API_KEY(here used with Z.AI). The reranker already usesSURREAL_MEMORY_RERANKER_API_KEY; both dedicated variables can point to the same LiteLLM virtual key and endpoint.Changes
OPENROUTER_API_KEY.Type of Change
Testing
Operational note
A production
consolidateis active; this PR does not touch it or the cluster. Local environment.d now contains matching dedicated embedding/reranker LiteLLM keys while preserving the original ambient Z.AI key; a final post-upgrade smem recall is needed after the consolidation completes.