fix: bound semantic keyset scans - #280
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
SurrealDB 3.2 was scanning the full remaining suffix of neuron/synapse tables for each keyset page. A single open-ended record range changed the operator to RecordIdScan but still visited most of the suffix. These bounded adjacent leading-character ranges cap each scan interval; the original exclusive ID predicate remains authoritative, and pages continue into the next interval when the prior one has too few matching rows.
Test plan
pytest tests/ -m "not stress" -n autopasses locally (7,748 passed, 179 skipped, 1 xfailed).ruff check src/ tests/clean.ruff format --check src/ tests/clean.mypy src/ --ignore-missing-importsclean.Verified by
@acidkill.