Skip to content

Remove Field of View's unused board-cell selection - #229

Merged
acrosman merged 1 commit into
mainfrom
fix/217-remove-unused-peripheral-selection
Oct 4, 2026
Merged

acrosman merged 1 commit into
mainfrom
fix/217-remove-unused-peripheral-selection

Conversation

@acrosman

@acrosman acrosman commented Oct 4, 2026

Copy link
Copy Markdown
Owner

Fixes #217.

render.updatePeripheralSelectionVisual had tests but nothing called it, so the .fov-cell--selected styles never applied. The side "Which Square Was the Toy In" grid already marks the player's choice, so this PR takes the issue's second option and removes the dead code:

  • updatePeripheralSelectionVisual from app/games/field-of-view/render.js
  • Its three tests in tests/render.test.js
  • The .fov-cell--selected and .fov-stage--response .fov-cell--selected rules in style.css
  • The CLAUDE.md paragraph that described the response-phase selection wash

The player won't see any change.

Testing: npm run lint is clean, and npm run test:coverage passes (54 suites, 2112 tests, thresholds met).

Signed: Claude Code for Aaron Crosman

🤖 Generated with Claude Code

updatePeripheralSelectionVisual was tested but never called, so the
.fov-cell--selected styles never applied. The side location grid is the
only marker for the chosen square, so delete the function, its tests,
both CSS rules, and the CLAUDE.md note that described them.

Fixes #217

Signed: Claude Code for Aaron Crosman

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@acrosman
acrosman merged commit fa821f8 into main Oct 4, 2026
7 checks passed
@acrosman
acrosman deleted the fix/217-remove-unused-peripheral-selection branch October 4, 2026 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Field of View: board cell over the mask never shows the chosen location

1 participant