Repository navigation
Remove Field of View's unused board-cell selection - #229
Merged
Merged
Conversation
updatePeripheralSelectionVisual was tested but never called, so the .fov-cell--selected styles never applied. The side location grid is the only marker for the chosen square, so delete the function, its tests, both CSS rules, and the CLAUDE.md note that described them. Fixes #217 Signed: Claude Code for Aaron Crosman Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #217.
render.updatePeripheralSelectionVisualhad tests but nothing called it, so the.fov-cell--selectedstyles never applied. The side "Which Square Was the Toy In" grid already marks the player's choice, so this PR takes the issue's second option and removes the dead code:updatePeripheralSelectionVisualfromapp/games/field-of-view/render.jstests/render.test.js.fov-cell--selectedand.fov-stage--response .fov-cell--selectedrules instyle.cssCLAUDE.mdparagraph that described the response-phase selection washThe player won't see any change.
Testing:
npm run lintis clean, andnpm run test:coveragepasses (54 suites, 2112 tests, thresholds met).Signed: Claude Code for Aaron Crosman
🤖 Generated with Claude Code