Repository navigation
Stop Fine Tuning and Sound Sweep repeating the response question - #235
Merged
Merged
Conversation
In the response phase, the status line repeated the question in the
fieldset legend right below it ("Which sound matched the target?" twice
in Fine Tuning). Because the status line is an assertive live region,
screen readers also heard the question twice: once from the status
line and once from the legend as focus moved to the first answer key.
The status line now says "Your turn" in both games, so the legend is
the only question. "Listen..." during playback and the polite result
feedback are unchanged. Sound Sweep's "How to respond" slide, which
describes the status line, now mentions it.
Part of #223
Signed: Claude Code (Claude Opus 5.5) for Aaron Crosman
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both screenshots showed the response question twice. Retaken to the standard (1280x880 content, clipped to the game area after five rounds with the answer keys enabled), so the status line now reads "Your turn". The layout is unchanged, so the callout boxes stay where they are. Fixes #223 Signed: Claude Code (Claude Opus 5.5) for Aaron Crosman Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When answers opened, the status line showed the same question as the fieldset legend right below it. This happened in both Fine Tuning ("Which sound matched the target?") and Sound Sweep. The status line now says Your turn, so the legend is the only question.
Fixes #223
What changed and why
enterResponsePhase()in both games'index.jsnow callsannounce('Your turn'). "Listen…" during playback is unchanged, and so is the result feedback in the polite#*-feedbackregion.#ft-status/#ss-statusis inside anaria-live="assertive"region.announce()runs just before focus moves to the first answer key, and that key's focus announcement already includes the legend. So the question used to be spoken twice, back to back. Now the live region says "Your turn" and the legend gives the question once.tutorialScreenshot.pngfiles were retaken to the standard: 1280×880 content, clipped to the game area after five rounds, with the answer keys enabled. The layout didn't change, so the callout boxes stay where they are.Testing
npm run lintpasses, andnpm testpasses (2149 tests).--user-data-dirand confirmed the status line reads "Your turn" when answers open.For reviewers
Signed: Claude Code (Claude Opus 5.5) for Aaron Crosman
🤖 Generated with Claude Code