Skip to content

Stop Fine Tuning and Sound Sweep repeating the response question - #235

Merged
acrosman merged 2 commits into
mainfrom
fix/223-status-line-duplicate-question
Oct 19, 2026
Merged

acrosman merged 2 commits into
mainfrom
fix/223-status-line-duplicate-question

Conversation

@acrosman

Copy link
Copy Markdown
Owner

Summary

When answers opened, the status line showed the same question as the fieldset legend right below it. This happened in both Fine Tuning ("Which sound matched the target?") and Sound Sweep. The status line now says Your turn, so the legend is the only question.

Fixes #223

What changed and why

  • enterResponsePhase() in both games' index.js now calls announce('Your turn'). "Listen…" during playback is unchanged, and so is the result feedback in the polite #*-feedback region.
  • Screen reader behavior (checked as the issue asked). #ft-status / #ss-status is inside an aria-live="assertive" region. announce() runs just before focus moves to the first answer key, and that key's focus announcement already includes the legend. So the question used to be spoken twice, back to back. Now the live region says "Your turn" and the legend gives the question once.
  • Sound Sweep's "How to respond" slide describes the status line, so it now mentions "Your turn".
  • Both tutorialScreenshot.png files were retaken to the standard: 1280×880 content, clipped to the game area after five rounds, with the answer keys enabled. The layout didn't change, so the callout boxes stay where they are.

Testing

  • npm run lint passes, and npm test passes (2149 tests).
  • Updated tests now assert the exact "Your turn" text. The Fine Tuning test also checks that the status text differs from the legend.
  • Ran both games in the app with an isolated --user-data-dir and confirmed the status line reads "Your turn" when answers open.

For reviewers

  • The wording: "Your turn" was one of the issue's suggestions. It is short enough not to delay the focus announcement.
  • After an answer, the status still says "Your turn" while the keys are disabled, until the next trial says "Listen…". During a session that lasts 500 ms. After a practice answer it stays up behind the coach. That behavior is unchanged from before (the question stayed up the same way).

Signed: Claude Code (Claude Opus 5.5) for Aaron Crosman

🤖 Generated with Claude Code

acrosman and others added 2 commits October 18, 2026 21:03
In the response phase, the status line repeated the question in the
fieldset legend right below it ("Which sound matched the target?" twice
in Fine Tuning). Because the status line is an assertive live region,
screen readers also heard the question twice: once from the status
line and once from the legend as focus moved to the first answer key.

The status line now says "Your turn" in both games, so the legend is
the only question. "Listen..." during playback and the polite result
feedback are unchanged. Sound Sweep's "How to respond" slide, which
describes the status line, now mentions it.

Part of #223

Signed: Claude Code (Claude Opus 5.5) for Aaron Crosman
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both screenshots showed the response question twice. Retaken to the
standard (1280x880 content, clipped to the game area after five rounds
with the answer keys enabled), so the status line now reads "Your
turn". The layout is unchanged, so the callout boxes stay where they
are.

Fixes #223

Signed: Claude Code (Claude Opus 5.5) for Aaron Crosman
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@acrosman
acrosman merged commit 60f5e7b into main Oct 19, 2026
7 checks passed
@acrosman
acrosman deleted the fix/223-status-line-duplicate-question branch October 19, 2026 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fine Tuning and Sound Sweep repeat the response question twice

1 participant