Skip to content

using js-cookie@^3.1 instead of js-cookie@^2.2.0 #74

Description

@lotfe-obaid

In our app we use js-cookie@^3.1, and when i tried to down grade to version 2.2, my app doesn't function correctly.
so i want to keep using js-cookie@^3.1
i fixed this by:
In gems/abraham-2.5.1/app/assets/javascripts/abraham/index.js i changed
//= require js-cookie/src/js.cookie
to:
//= require js-cookie/dist/js.cookie

js-cookie/dist/js.cookie is the default path for version 3.1
i would like to ask , is there a way to do that without modifying the gem?

Activity

  1. oclef commented on Apr 5, 2023

    @oclef

    see my solution to issue

    #69

    It should work for you

  2. lotfe-obaid commented on Apr 5, 2023

    @lotfe-obaid
    Author

    is already working, but i want to keep the gem as it is without modifying anything, i would like to know if there is a way to override the path
    //= require js-cookie/src/js.cookie
    to:
    //= require js-cookie/dist/js.cookie
    from outside the gem

    update: i saw this reply but i am looking for a better solution
    #31 (comment)

  3. lotfe-obaid commented on Apr 9, 2023

    @lotfe-obaid
    Author

    @jabbett it would be appreciated if you could upgrade js-cookies to any newer version with the newer path js-cookie/dist/js.cookie this is our major compatibility issue which forces us to modify on the gem.
    i have created a pull request #76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions