Repository navigation
Description
Delivery bundle: B: Lifecycle correctness and status. See #397 and #368 for the four-PR stack.
Parent: #391
Roadmap: #368
Plan item: PR-02
Priority: P1
Dependencies: None
Kubernetes support: Rolling upstream-maintained minors; use the oldest/newest boundaries pinned in config/kubernetes-versions.env. See #368 for the current policy. Unrun jobs are not passed validation.
Problem Statement
Evidence: KafkaCluster adds finalizers after component reconciliation (controllers/kafkacluster_controller.go:186), KafkaTopic after topic changes (controllers/kafkatopic_controller.go:184), and KafkaUser after certificate/ACL work (controllers/kafkauser_controller.go:292).
Proposed Solution
Files: Those three controllers and their existing tests, including controllers/kafkacluster_controller_test.go, controllers/kafkatopic_controller_kafka_test.go, and controller integration tests under controllers/tests/.
Interface contract: Persist each required finalizer before performing work whose cleanup it protects. Continue with the API response or explicitly requeue; KafkaCluster's existing filter does not enqueue finalizer-only changes.
- Add deletion-during-first-reconcile tests for cluster, topic, and user; assert no protected external side effect precedes finalizer persistence.
- Add a restart-after-create test and a finalizer-write-failure test; failed persistence must prevent the external creation.
- Reorder lifecycle handling without changing cleanup ordering, retention, or unmanaged-topic behavior. Do not make deletion depend on provisioning prerequisites that are unnecessary for cleanup.
- Verify a resource does not stall after a finalizer-only update, including with the production predicates installed.
- Validate with
go test ./controllers ./controllers/tests; use envtest and mocked external clients for lifecycle ordering.
Done when: Provisioning/deletion races have explicit coverage and cleanup ownership is persisted first.
Delivery: Four consolidated PRs, approved November 16, 2026: A -> B -> C; D branches from A. Foundation is #395. The 22 PR-XX identifiers are work-item IDs, not separate PRs. Preserve every work-item acceptance criterion and native dependency. No gated experiment is automatically enabled, and no issue is complete merely because one PR references it. D must satisfy its native #375 gate, including lifecycle-domain signals assigned to B; branching from A does not waive that merge prerequisite. Write focused regression tests first; record exact commands/results and run make check plus this issue's real-cluster/measurement gates.
Alternatives Considered
Twenty-two individual PRs add unnecessary integration overhead, while one omnibus PR obscures correctness and rollout boundaries. Deliver this scope in its approved dependency-aligned bundle. Do not expand into deferred consistency, storage, or concurrency changes without their own decision gates.
Additional Context
Baseline: 95138e0d; detailed roadmap scope: #368, section PR-02. The roadmap #368 and its native sub-issues are the planning source of truth. No planning document is committed in the final PR diffs. Re-read affected source and overlapping work before implementation. Historical baseline test passes are not validation of this change.
Activity
amuraru commentedon Nov 17, 2026
Cleanup-ownership scope is consolidated into #391 under #368. Existing finalizer work remains local/uncommitted and must pass focused review; this closure is not a claim that it shipped.