Skip to content

[PR-04] Non-Blocking, Bounded Topic Deletion #372

Closed as not planned
Closed as not planned

Description

@amuraru

Delivery bundle: B: Lifecycle correctness and status. See #397 and #368 for the four-PR stack.

Parent: #391
Roadmap: #368
Plan item: PR-04
Priority: P1
Dependencies: PR-03

Kubernetes support: Rolling upstream-maintained minors; use the oldest/newest boundaries pinned in config/kubernetes-versions.env. See #368 for the current policy. Unrun jobs are not passed validation.

Problem Statement

Evidence: pkg/kafkaclient/topics.go:89-112 polls indefinitely without context; controllers/kafkatopic_controller.go requests synchronous deletion.

Proposed Solution

Files: pkg/kafkaclient/topics.go, pkg/kafkaclient/topics_test.go, pkg/kafkaclient/client.go and mocks if signatures change, controllers/kafkatopic_controller.go, and topic/controller tests.

Interface contract: Reconciliation submits deletion and observes completion across reconciles. Keep the finalizer while the topic still exists. Migrate or retain a bounded compatibility wrapper for existing DeleteTopic(string, bool) error callers; update every affected mock.

  • Add TestTopicDeletionPendingRequeues, TestTopicDeletionAlreadyAbsent, and a disabled-deletion test; assert bounded reconcile return and correct finalizer retention/removal.
  • Add cancellation and restart-mid-deletion tests; no goroutine or worker may remain occupied by an unbounded poll.
  • Replace the synchronous controller wait with observe-and-requeue behavior. Expose useful pending/error state without introducing a busy loop.
  • Validate with go test ./pkg/kafkaclient ./controllers ./controllers/tests and a Kind test with real Kafka topic deletion disabled.

Done when: A stuck topic deletion remains visible and retryable without starving unrelated topics.

Delivery: Four consolidated PRs, approved November 16, 2026: A -> B -> C; D branches from A. Foundation is #395. The 22 PR-XX identifiers are work-item IDs, not separate PRs. Preserve every work-item acceptance criterion and native dependency. No gated experiment is automatically enabled, and no issue is complete merely because one PR references it. D must satisfy its native #375 gate, including lifecycle-domain signals assigned to B; branching from A does not waive that merge prerequisite. Write focused regression tests first; record exact commands/results and run make check plus this issue's real-cluster/measurement gates.

Alternatives Considered

Twenty-two individual PRs add unnecessary integration overhead, while one omnibus PR obscures correctness and rollout boundaries. Deliver this scope in its approved dependency-aligned bundle. Do not expand into deferred consistency, storage, or concurrency changes without their own decision gates.

Additional Context

Baseline: 95138e0d; detailed roadmap scope: #368, section PR-04. The roadmap #368 and its native sub-issues are the planning source of truth. No planning document is committed in the final PR diffs. Re-read affected source and overlapping work before implementation. Historical baseline test passes are not validation of this change.

Activity

  1. added theissue type on Nov 16, 2026
  2. amuraru commented on Nov 17, 2026

    @amuraru
    Author

    Bounded observe-and-requeue topic deletion is consolidated into #391 under #368. Preserve finalizers until absence and test stalled deletion/restart. The broad #371 refactor is no longer a prerequisite. Not marked implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions