Skip to content

[PR-11] Dependency Watches and Precise Predicates #379

Closed as not planned
Closed as not planned

Description

@amuraru

Delivery bundle: C: Convergence, APIs, and gated scalability. See #395 and #368 for the four-PR stack.

Parent: #393
Roadmap: #368
Plan item: PR-11
Priority: P2
Dependencies: None

Kubernetes support: Rolling upstream-maintained minors; use the oldest/newest boundaries pinned in config/kubernetes-versions.env. See #368 for the current policy. Unrun jobs are not passed validation.

Problem Statement

Evidence: controllers/kafkacluster_controller.go:380-440 repeats owned-kind registrations and ignores Pod status-only changes; topic/user setups lack complete referenced-dependency watches.

Proposed Solution

Files: KafkaCluster/Topic/User setup functions, controllers/controller_common.go, pkg/k8sutil/cache.go, predicate/unit tests and controllers/tests/.

Interface contract: Use per-watch predicates and indexed dependency-to-primary mapping. Normalize a missing ClusterRef.Namespace to the referring object's namespace. Keep status-driven Cruise Control work and management annotations observable.

  • Add tests for Pod readiness transitions, relevant PVC state changes, TLS Secret rotation, KafkaCluster recovery, management annotation changes, deletion timestamps, and broker-status changes.
  • Consolidate duplicate Owns registrations while preserving create/delete/self-healing behavior.
  • Add only relevant dependency watches and index-backed mappings; do not scan every topic/user per Secret event.
  • Verify optional integrations remain optional and no blanket generation predicate filters required signals.
  • Validate with go test ./controllers ./controllers/tests ./pkg/k8sutil; assert dependency changes enqueue the expected resources without unrelated fanout.

Done when: Dependencies trigger prompt convergence and predicates reduce noise without hiding state changes.

Delivery: Four consolidated PRs, approved November 16, 2026: A -> B -> C; D branches from A. Foundation is #395. The 22 PR-XX identifiers are work-item IDs, not separate PRs. Preserve every work-item acceptance criterion and native dependency. No gated experiment is automatically enabled, and no issue is complete merely because one PR references it. D must satisfy its native #375 gate, including lifecycle-domain signals assigned to B; branching from A does not waive that merge prerequisite. Write focused regression tests first; record exact commands/results and run make check plus this issue's real-cluster/measurement gates.

Alternatives Considered

Twenty-two individual PRs add unnecessary integration overhead, while one omnibus PR obscures correctness and rollout boundaries. Deliver this scope in its approved dependency-aligned bundle. Do not expand into deferred consistency, storage, or concurrency changes without their own decision gates.

Additional Context

Baseline: 95138e0d; detailed roadmap scope: #368, section PR-11. The roadmap #368 and its native sub-issues are the planning source of truth. No planning document is committed in the final PR diffs. Re-read affected source and overlapping work before implementation. Historical baseline test passes are not validation of this change.

Activity

  1. added theissue type on Nov 16, 2026
  2. amuraru commented on Nov 17, 2026

    @amuraru
    Author

    Reproduced dependency-convergence failures move to #394 under #368. Add only necessary watches/predicates/mappings; blanket registration cleanup is not a deliverable. Superseded, not implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions