Skip to content

[PR-13] Existing Validation Expressed in Schema/CEL #381

Closed as not planned
Closed as not planned

Description

@amuraru

Delivery bundle: C: Convergence, APIs, and gated scalability. See #395 and #368 for the four-PR stack.

Parent: #394
Roadmap: #368
Plan item: PR-13
Priority: P2
Dependencies: None; the rolling Kubernetes support policy is established

Kubernetes support: Rolling upstream-maintained minors; use the oldest/newest boundaries pinned in config/kubernetes-versions.env. See #368 for the current policy. Unrun jobs are not passed validation.

Problem Statement

Evidence: Topic schema permits zero even though the webhook rejects it; APIs have no XValidation markers. Listener validation is implemented in Go.

Proposed Solution

Files: Topic/cluster API types, pkg/webhooks/kafkacluster_validator.go, pkg/webhooks/kafkatopic_validator.go, generated CRDs/chart copies, existing validator/API/envtest tests.

Interface contract: Preserve existing validation semantics, including positive values or -1 for topic partitions/replication factor. Move only locally decidable rules that the supported server range can enforce. Do not alter list ordering or add new immutability rules.

  • Use the current managed Kubernetes minimum minor to choose supported CEL syntax and bound expression cost with suitable schema limits.
  • Add API-server admission tests for zero, -1, positive values, duplicates, port collisions, defaults, and representative existing manifests.
  • Migrate suitable existing constraints, retaining complex rules in Go when CEL would be brittle or costly.
  • Remove duplicated webhook validation only after schema enforcement is equivalent across the supported server range.
  • Run make generate manifests, API tests, go test ./pkg/webhooks ./controllers/tests, and compatibility-matrix admission tests.

Done when: Equivalent validation is enforced with fewer webhook dependencies and no unapproved contract changes.

Delivery: Four consolidated PRs, approved November 16, 2026: A -> B -> C; D branches from A. Foundation is #395. The 22 PR-XX identifiers are work-item IDs, not separate PRs. Preserve every work-item acceptance criterion and native dependency. No gated experiment is automatically enabled, and no issue is complete merely because one PR references it. D must satisfy its native #375 gate, including lifecycle-domain signals assigned to B; branching from A does not waive that merge prerequisite. Write focused regression tests first; record exact commands/results and run make check plus this issue's real-cluster/measurement gates.

Alternatives Considered

Twenty-two individual PRs add unnecessary integration overhead, while one omnibus PR obscures correctness and rollout boundaries. Deliver this scope in its approved dependency-aligned bundle. Do not expand into deferred consistency, storage, or concurrency changes without their own decision gates.

Support-policy decision updated November 16, 2026: Rolling upstream-maintained minors and managed oldest/newest compatibility boundaries; see #368. The decision-only #381 → #386 blocker is satisfied and removed. Other tooling/schema work remains open and requires its own tests.

Additional Context

Baseline: 95138e0d; detailed roadmap scope: #368, section PR-13. The roadmap #368 and its native sub-issues are the planning source of truth. No planning document is committed in the final PR diffs. Re-read affected source and overlapping work before implementation. Historical baseline test passes are not validation of this change.

Activity

  1. added theissue type on Nov 16, 2026
  2. amuraru commented on Nov 17, 2026

    @amuraru
    Author

    Removed from active scope under #368: relocating working validation into CEL/schema is not justified by a demonstrated failure. Preserve existing validation contracts; no schema migration claimed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions