Skip to content

[PR-17] Native Authenticated Metrics Serving #385

Closed as not planned
Closed as not planned

Description

@amuraru

Delivery bundle: D: HA and secure deployment. See #395 and #368 for the four-PR stack.

Parent: #392
Roadmap: #368
Plan item: PR-17
Priority: P2
Dependencies: PR-07

Kubernetes support: Rolling upstream-maintained minors; use the oldest/newest boundaries pinned in config/kubernetes-versions.env. See #368 for the current policy. Unrun jobs are not passed validation.

Problem Statement

Evidence: Manager metrics bind without an authentication filter; Helm uses kube-rbac-proxy, while its PodMonitor targets the raw metrics port even when the proxy is enabled.

Proposed Solution

Files: main.go, chart metrics/proxy RBAC and Service templates, charts/kafka-operator/templates/podmonitor.yaml, deployment template, values/schema, and metrics tests/docs.

Interface contract: Use controller-runtime secure serving and filters.WithAuthenticationAndAuthorization; coordinate TokenReview/SubjectAccessReview permissions, serving trust, reader RBAC, and scrape endpoints. Keep a documented compatibility path during migration.

  • Add tests for unauthenticated denial, authenticated unauthorized denial, and authorized scrape success.
  • Render/test the chart and PodMonitor for legacy-proxy and native-auth modes; verify actual requests reach the protected endpoint.
  • Implement the migration and explicitly disable/remove the legacy raw endpoint when appropriate. Do not leave an accidental bypass.
  • Validate chart rendering/lint plus Kind scrape tests and compare resource usage to the PR-07 baseline.

Done when: Authorized scraping works, unauthorized requests fail, and removing the sidecar does not break monitoring.

Delivery: Four consolidated PRs, approved November 16, 2026: A -> B -> C; D branches from A. Foundation is #395. The 22 PR-XX identifiers are work-item IDs, not separate PRs. Preserve every work-item acceptance criterion and native dependency. No gated experiment is automatically enabled, and no issue is complete merely because one PR references it. D must satisfy its native #375 gate, including lifecycle-domain signals assigned to B; branching from A does not waive that merge prerequisite. Write focused regression tests first; record exact commands/results and run make check plus this issue's real-cluster/measurement gates.

Alternatives Considered

Twenty-two individual PRs add unnecessary integration overhead, while one omnibus PR obscures correctness and rollout boundaries. Deliver this scope in its approved dependency-aligned bundle. Do not expand into deferred consistency, storage, or concurrency changes without their own decision gates.

Additional Context

Baseline: 95138e0d; detailed roadmap scope: #368, section PR-17. The roadmap #368 and its native sub-issues are the planning source of truth. No planning document is committed in the final PR diffs. Re-read affected source and overlapping work before implementation. Historical baseline test passes are not validation of this change.

Activity

  1. added theissue type on Nov 16, 2026
  2. amuraru commented on Nov 17, 2026

    @amuraru
    Author

    Actual protected scrape/proxy wiring moves to #392 under #368. Keep the existing kube-rbac-proxy architecture; native-auth sidecar replacement is removed from scope. Superseded, not implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions