Skip to content

fix(operator): skip irrelevant Kafka checks and restore user Secrets - #400

Open
amuraru wants to merge 5 commits into
modernize/lifecyclefrom
fix/issue-394-admission
Open

amuraru wants to merge 5 commits into
modernize/lifecyclefrom
fix/issue-394-admission

Conversation

@amuraru

@amuraru amuraru commented Nov 17, 2026

Copy link
Copy Markdown

Description

Skip Kafka admission checks only for irrelevant topic updates, preserving fail-closed transitions, and restore deleted CSR-mode user Secrets through owned-Secret events. Fixes #394; depends on #397.

go test ./pkg/webhooks ./controllers -count=1 and combined make -C .worktrees/improvements-integration check ENVTEST_K8S_VERSION=1.35.0 passed. CSR recovery envtest passed on 1.35/1.37; real 1.35 admission passed on combined integration. Full E2E suite not run.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

amuraru and others added 5 commits November 16, 2026 18:50
…icts

Retry fresh API reads and status writes without repeating external submission. Preserve stop-operation identity and retry history, reject stale object/task identities, add seven regression cases, and document the remaining submit-before-persist crash window.

Refs #369.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Reuse the selected operation for the first status write and read directly only when retrying a conflict. Cover conflict-free submission, retry, and stop paths. Refs #369.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Retain Kubernetes validation and fail-closed Kafka checks for spec and managedBy changes, including adoption.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Watch KafkaUser-owned Secrets only when certificate signing is enabled, preserving existing ownership and optional cert-manager behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Watch owned Secret deletions without reacting to self-generated create or update events that can race the CSR annotation cache. Reproduce duplicate CSR creation under held Secret cache visibility and verify deletion-driven Secret and CSR recovery without extras.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@amuraru
amuraru force-pushed the modernize/lifecycle branch from db822f3 to be634e1 Compare November 21, 2026 14:15

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant