Skip to content

fix(serving): route alerts to the leader and correct proxy wiring - #401

Draft
amuraru wants to merge 9 commits into
modernize/lifecyclefrom
fix/issue-392-serving
Draft

amuraru wants to merge 9 commits into
modernize/lifecyclefrom
fix/issue-392-serving

Conversation

@amuraru

@amuraru amuraru commented Nov 17, 2026 •

Copy link
Copy Markdown

Description

Route alerts only to the serving leader and keep webhook standbys ready. Fixes #392; depends on #397. Preserve baseline unauthenticated HTTP metrics scraping; managed TLS/auth scraping is deferred. Old-chart rollout can briefly lose alert endpoints.

Validation: env -u GOROOT go test ./controllers . -run 'Test(Alert|WebhookReadinessConditionalRegistration)' -count=1 passed. helm lint charts/kafka-operator --strict --kube-version "$version" and helm template kafka-operator charts/kafka-operator --kube-version "$version" passed for version=1.35.0 and 1.37.0; focused CI render assertions and git diff --check passed. Full suite, race detector and live-cluster checks were not rerun for this correction.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

amuraru and others added 8 commits November 16, 2026 18:50
…icts

Retry fresh API reads and status writes without repeating external submission. Preserve stop-operation identity and retry history, reject stale object/task identities, add seven regression cases, and document the remaining submit-before-persist crash window.

Refs #369.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Reuse the selected operation for the first status write and read directly only when retrying a conflict. Cover conflict-free submission, retry, and stop paths. Refs #369.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Return alert listener bind failures, drain requests on manager cancellation, and close connections after shutdown timeout or serve failure. Add focused lifecycle regressions.

Refs #392

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Align PodMonitor protocol and port with proxy mode, keep raw metrics on loopback behind the proxy, and honor the configured upstream port without embedded bind-address quotes. Cover default/custom ports and proxy/direct modes in the existing chart validation block.

Refs #392

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Scope routing label updates to uncached, UID-checked installation Pods, fail admission closed on observed cancellation, and bound self-label cleanup. Preserve legacy identity-absent listeners, usable webhook standbys, Kafka-independent liveness, and election identity bytes.

Refs #392

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve the configured proxy subject, avoid duplicate shared subjects, and test default, custom, shared and externally managed RBAC cases. Document caller-owned scrape authentication/trust, deferred managed integration and existing certificate renewal limits.

Refs #392

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Exercise the live admission gate on an explicitly reused HTTP connection while the serving flag remains set, so stale routing cannot bypass observed manager cancellation.

Refs #392

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Restore the existing supported-version Helm lint/render checks instead of maintaining the expanded configuration matrix and formatting-sensitive assertions. Consolidate listener setup and duplicated cancellation checks while retaining the focused serving failure regressions and explicit reused-connection test. Condense installation guidance without changing runtime code or chart templates.

Refs #392, #401

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@amuraru
amuraru marked this pull request as draft November 17, 2026 18:47
Defer incomplete protected scraping, retain custom-port alignment, and add focused Helm render regressions without changing alert serving.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@amuraru
amuraru force-pushed the modernize/lifecycle branch from db822f3 to be634e1 Compare November 21, 2026 14:15

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant