Repository navigation
Conversation
…icts Retry fresh API reads and status writes without repeating external submission. Preserve stop-operation identity and retry history, reject stale object/task identities, add seven regression cases, and document the remaining submit-before-persist crash window. Refs #369. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Reuse the selected operation for the first status write and read directly only when retrying a conflict. Cover conflict-free submission, retry, and stop paths. Refs #369. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Return alert listener bind failures, drain requests on manager cancellation, and close connections after shutdown timeout or serve failure. Add focused lifecycle regressions. Refs #392 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Align PodMonitor protocol and port with proxy mode, keep raw metrics on loopback behind the proxy, and honor the configured upstream port without embedded bind-address quotes. Cover default/custom ports and proxy/direct modes in the existing chart validation block. Refs #392 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Scope routing label updates to uncached, UID-checked installation Pods, fail admission closed on observed cancellation, and bound self-label cleanup. Preserve legacy identity-absent listeners, usable webhook standbys, Kafka-independent liveness, and election identity bytes. Refs #392 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve the configured proxy subject, avoid duplicate shared subjects, and test default, custom, shared and externally managed RBAC cases. Document caller-owned scrape authentication/trust, deferred managed integration and existing certificate renewal limits. Refs #392 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Exercise the live admission gate on an explicitly reused HTTP connection while the serving flag remains set, so stale routing cannot bypass observed manager cancellation. Refs #392 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Restore the existing supported-version Helm lint/render checks instead of maintaining the expanded configuration matrix and formatting-sensitive assertions. Consolidate listener setup and duplicated cancellation checks while retaining the focused serving failure regressions and explicit reused-connection test. Condense installation guidance without changing runtime code or chart templates. Refs #392, #401 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
amuraru
marked this pull request as draft
November 17, 2026 18:47
Defer incomplete protected scraping, retain custom-port alignment, and add focused Helm render regressions without changing alert serving. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
amuraru
force-pushed
the
modernize/lifecycle
branch
from
November 21, 2026 14:15
db822f3 to
be634e1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Route alerts only to the serving leader and keep webhook standbys ready. Fixes #392; depends on #397. Preserve baseline unauthenticated HTTP metrics scraping; managed TLS/auth scraping is deferred. Old-chart rollout can briefly lose alert endpoints.
Validation:
env -u GOROOT go test ./controllers . -run 'Test(Alert|WebhookReadinessConditionalRegistration)' -count=1passed.helm lint charts/kafka-operator --strict --kube-version "$version"andhelm template kafka-operator charts/kafka-operator --kube-version "$version"passed forversion=1.35.0and1.37.0; focused CI render assertions andgit diff --checkpassed. Full suite, race detector and live-cluster checks were not rerun for this correction.Type of Change
Checklist