Skip to content

fix(controllers): preserve cleanup ownership and bound topic deletion - #402

Open
amuraru wants to merge 5 commits into
modernize/lifecyclefrom
fix/issue-391-lifecycle
Open

amuraru wants to merge 5 commits into
modernize/lifecyclefrom
fix/issue-391-lifecycle

Conversation

@amuraru

@amuraru amuraru commented Nov 17, 2026

Copy link
Copy Markdown

Description

Preserve cleanup ownership and legacy ACL identity, and requeue topic deletion without blocking. Fixes #391; depends on #397.

make -C .worktrees/issue-391-lifecycle check ENVTEST_K8S_VERSION=1.35.0 passed. Real 1.35 combined smoke passed PKI cleanup/GC, pending-topic progress across restart, and eventual Kafka topic deletion. Full E2E suite not run.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

amuraru and others added 5 commits November 16, 2026 18:50
…icts

Retry fresh API reads and status writes without repeating external submission. Preserve stop-operation identity and retry history, reject stale object/task identities, add seven regression cases, and document the remaining submit-before-persist crash window.

Refs #369.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Reuse the selected operation for the first status write and read directly only when retrying a conflict. Cover conflict-free submission, retry, and stop paths. Refs #369.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
)

Persist finalizers and discoverable cleanup identity before provisioning. Preserve certificate and ACL cleanup ownership across interrupted provisioning.

Submit Kafka topic deletion without waiting, retain finalizers while pending, and observe absence on a subsequent reconcile.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Persist a recovered legacy principal before deleting its owned Certificate or Secret, and stop cleanup when that metadata write fails.

Cover failed ACL cleanup followed by restart and failed identity checkpoint writes without losing cleanup ownership.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ate issuance (#391)

Reconcile a cert-manager KafkaUser with topic grants before its Secret is
issued, then after issuance, and verify the issued principal is recorded
before ACL creation and used for ACL cleanup on deletion.
@amuraru
amuraru force-pushed the modernize/lifecycle branch from db822f3 to be634e1 Compare November 21, 2026 14:15

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant