Repository navigation
feat(kafka): support alternate authenticated JDK downloads - #403
Merged
Merged
Conversation
Keep Oracle downloads as the default and support versioned alternate sources with an optional BuildKit API-key secret. Document generic usage and leave release overrides commented out. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use only the Java major version as the alternate download directory and reserve java_download_version for archive filenames. Keep Oracle URLs unchanged and align the download documentation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
azun
approved these changes
Nov 18, 2026
amuraru
added a commit
to adobe/zookeeper-operator
that referenced
this pull request
Nov 18, 2026
* feat(docker): support alternate authenticated JDK downloads Port alternate Java download sources and optional BuildKit-secret authentication from adobe/koperator#403. Upgrade the ZooKeeper base image to Debian Trixie while retaining Oracle and Java 25 defaults. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(docker): support major-only JDK mirrors and Java 21 runtime Use the documented major-only layout for alternate JDK mirrors. Compile the zu helper to Java 21 bytecode while retaining JDK 25 as the builder and default runtime, and keep image descriptions accurate for alternate runtimes. Validated the complete amd64 image with authenticated Oracle JDK 21.0.13.1+4 downloads, ZooKeeper startup and live zu client access. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * refactor(docker): derive helper Java targets from the base image Keep java_version in the base Dockerfile as the single runtime setting. Read the selected base JDK release metadata in the native helper builder and use one Gradle property for Java source/target compatibility and the Kotlin JVM target. Verified full Java 21 and Java 25 image builds, matching helper bytecode versions, ZooKeeper startup and live helper operations; all 35 build-script tests pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(zu): restore bare Gradle builds using the central Java default Default javaVersion lazily from the base Dockerfile when no explicit Gradle property is supplied. This restores the CodeQL ./gradlew build command while retaining Java 25 as the shared runtime and compilation default. Docker builds continue to derive targets from the selected base image. Verified bare Gradle build, explicit Java 21 override, full Java 25 image/runtime smoke tests and 35 script regression tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support alternate JDK sources and optional API-key authentication via BuildKit secrets. Oracle remains the default; workflow overrides stay commented out. No JDK upgrade.
Passed:
make check,actionlint -shellcheck= .github/workflows/publish-kafka-docker.yml, anddocker buildx build --check docker/kafka.Type of Change
Checklist