Skip to content

feat(kafka): support alternate authenticated JDK downloads - #403

Merged
azun merged 3 commits into
mainfrom
fix/critical-security-issue
Nov 18, 2026
Merged

azun merged 3 commits into
mainfrom
fix/critical-security-issue

Conversation

@amuraru

@amuraru amuraru commented Nov 18, 2026 •

Copy link
Copy Markdown

Description

Support alternate JDK sources and optional API-key authentication via BuildKit secrets. Oracle remains the default; workflow overrides stay commented out. No JDK upgrade.

Passed: make check, actionlint -shellcheck= .github/workflows/publish-kafka-docker.yml, and docker buildx build --check docker/kafka.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

Keep Oracle downloads as the default and support versioned alternate sources with an optional BuildKit API-key secret. Document generic usage and leave release overrides commented out.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
amuraru and others added 2 commits November 18, 2026 12:55
Use only the Java major version as the alternate download directory and reserve java_download_version for archive filenames. Keep Oracle URLs unchanged and align the download documentation.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@azun
azun merged commit e12095f into main Nov 18, 2026
15 checks passed
@azun
azun deleted the fix/critical-security-issue branch November 18, 2026 15:23
amuraru added a commit to adobe/zookeeper-operator that referenced this pull request Nov 18, 2026
* feat(docker): support alternate authenticated JDK downloads

Port alternate Java download sources and optional BuildKit-secret authentication from adobe/koperator#403. Upgrade the ZooKeeper base image to Debian Trixie while retaining Oracle and Java 25 defaults.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix(docker): support major-only JDK mirrors and Java 21 runtime

Use the documented major-only layout for alternate JDK mirrors. Compile the zu helper to Java 21 bytecode while retaining JDK 25 as the builder and default runtime, and keep image descriptions accurate for alternate runtimes.

Validated the complete amd64 image with authenticated Oracle JDK 21.0.13.1+4 downloads, ZooKeeper startup and live zu client access.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* refactor(docker): derive helper Java targets from the base image

Keep java_version in the base Dockerfile as the single runtime setting. Read the selected base JDK release metadata in the native helper builder and use one Gradle property for Java source/target compatibility and the Kotlin JVM target.

Verified full Java 21 and Java 25 image builds, matching helper bytecode versions, ZooKeeper startup and live helper operations; all 35 build-script tests pass.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix(zu): restore bare Gradle builds using the central Java default

Default javaVersion lazily from the base Dockerfile when no explicit Gradle property is supplied. This restores the CodeQL ./gradlew build command while retaining Java 25 as the shared runtime and compilation default. Docker builds continue to derive targets from the selected base image.

Verified bare Gradle build, explicit Java 21 override, full Java 25 image/runtime smoke tests and 35 script regression tests.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants