Repository navigation
fix(controller): skip unchanged ConfigMap and ServiceAccount writes - #112
Conversation
|
Completed the actual Talos pre-flight review at Fresh local validation passed:
Hosted checks refreshed at 2026-11-17 20:40 UTC: all active completed checks passed; Kubernetes 1.34 e2e remains in progress. Superseded cancelled jobs are not failures of that active run. No local kind/e2e run. Approved ConfigMap/custom ServiceAccount guard scope is unchanged; broader #101/PR-08 and #103 work remains deferred. No merge performed. |
|
Resolved the aggregate CI status: e2e run 44168955056, attempt 2 passed at 2026-11-18 08:47:06 UTC on unchanged HEAD Fresh verification: every entry in Talos review remains complete with zero findings. No source changes, commits or merge performed; PR remains open. |
Guard owned data before existing updates while preserving conflicts and subsequent StatefulSet reconciliation. Cover no-ops, changes, removals and real API-server conflict retries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
a72bbf5 to
bf6367a
Compare
Keep the health lifecycle test compatible with the reconciler-local ZooKeeper client factory introduced by #117. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Change log description
Purpose of the change
Partial progress on #101, PR-08. This does not complete PR-08 or close #101.
What the code does
Compare ConfigMap
Data/BinaryDataand ServiceAccountImagePullSecretsbefore writing. Retain the existingUpdatebehavior when those fields change; leave StatefulSet, Service, status and resource-version handling unchanged.Regression cases cover no-op writes, concurrent-update conflicts and retries, owned-field removal, and scaling past an unchanged ServiceAccount. The resource cases run against both the fake client and a real Kubernetes 1.34.1 API server.
This removes demonstrated unnecessary mutation requests, not a proven stored-data write storm. No throughput improvement is claimed; default-aware convergence for other resources remains deferred.
How to verify it
Local validation used the isolated checkout at
.worktrees/controller-write-convergence:make -C .worktrees/controller-write-convergence testKUBEBUILDER_ASSETS="$PWD/.worktrees/controller-write-convergence/bin/k8s/k8s/1.34.1-darwin-arm64" go -C .worktrees/controller-write-convergence test -race -tags=envtest ./controllers -run '^TestEnvtest' -count=1make -C .worktrees/controller-write-convergence checkcd .worktrees/controller-write-convergence && golangci-lint run --new-from-rev=da85c962611ab87ce0ff122a0f8d865f6c8c968f ./controllers/...cd .worktrees/controller-write-convergence && golangci-lint run --build-tags=envtest --new-from-rev=da85c962611ab87ce0ff122a0f8d865f6c8c968f ./controllers/...git -C .worktrees/controller-write-convergence diff --checkRED verification: the unchanged ConfigMap and ServiceAccount cases both failed against the immutable original controller at
da85c96, loaded with a Go source overlay without changing the checkout. The final implementation passes both.Local kind/e2e was not run. The existing Kubernetes 1.34 hosted e2e workflow is requested with the
e2elabel.