Repository navigation
feat(api): validate storage configuration at admission (PR-16) - #118
Conversation
|
Hosted validation completed for commit
The duplicate initial e2e run was cancelled before executing any test steps: https://github.com/adobe/zookeeper-operator/actions/runs/44362507949 . Its cancelled placeholder check remains visible, and GitHub currently reports |
|
Metadata integration follow-up for The exact CI integration command passed locally. A targeted rerun of the failed metadata job also passed; CI run https://github.com/adobe/zookeeper-operator/actions/runs/44371831763 is now successful. No code, workflow, timeout or validation-gate changes were made. The shared fixture startup race remains outside PR-16; the independent e2e check continues to be watched. |
Implement PR-16 from #103 with explicit update-aware CEL storage validation, compatible case folding and the nested Retain default. Preserve all controller fallbacks and legacy-invalid unrelated updates; cover real API-server upgrade and rollback. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Document the CEL policy as a readable multiline breakdown while keeping its executable marker unchanged. Remove the legacy-specific sentence from generated CRD descriptions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Avoid the ZooKeeper startup race exposed by CI by polling the bounded srvr response before opening a client session. Preserve the shared 20-second readiness deadline and cover transient responses and stalled probes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
0daaf86 to
566270b
Compare
Change log description
Retain; retain controller fallbacks.Purpose of the change
PR-16 of #103. PVC retention migration remains deferred.
What the code does
Adds update-aware CEL, generated CRDs and admission/upgrade/rollback tests. The metadata fixture waits for serving readiness before opening sessions.
How to verify it
Passed locally:
make controller-gen generate;git diff --exit-code(generated drift);make checkmake test;make test-envtest;go vet ./...go test -tags=zkintegration ./pkg/zk -run '^TestMetadataCreate' -count=10 -timeout=4m -vgo test -race -tags=zkintegration ./pkg/zk -run '^TestMetadataCreate' -count=3 -timeout=4mHosted checks are tracked separately;
e2elabel enabled.