Repository navigation
Conversation
amuraru
force-pushed
the
refactor/controller-owned-field-convergence
branch
from
November 20, 2026 14:50
1bf1457 to
7751a9b
Compare
amuraru
force-pushed
the
refactor/controller-owned-field-convergence
branch
from
November 20, 2026 15:15
7751a9b to
86a181f
Compare
amuraru
force-pushed
the
refactor/controller-owned-field-convergence
branch
from
November 20, 2026 15:42
86a181f to
6e41abc
Compare
Use deterministic rendering and optimistic patches to avoid persisting unchanged resources. Persist upgrade status and reject stale resize snapshots before writing ZooKeeper metadata. Reconcile StatefulSets and Services with guarded apply and compatibility writes. Preserve immutable settings and unrelated ownership, keep complete sources for mounted volumes, and update Service exposure rules atomically without replacing allocated NodePorts. Resolve conflicting legacy seccomp annotations when applying explicit profiles. Document ownership and RBAC prerequisites and cover convergence, migration, and races in unit tests and an isolated shared envtest control plane. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Migrate the generic main field manager only when it owns the legacy StatefulSet marker. Test logging and scheduling migration and verify that unrelated main-owned fields remain untouched. Document a targeted cleanup for verified legacy Service DNS annotations without claiming arbitrary Service fields from main.
amuraru
force-pushed
the
refactor/controller-owned-field-convergence
branch
from
November 21, 2026 14:45
722f62e to
69a735f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Stop reconcile write churn and status loss
owner-rvStatefulSet label (every status write forced a StatefulSet write).AdditionalConfigkeys and Ready/Unready members, so unchanged clusters render stable output.clearUpgradeStatusnow writes the status subresource.2. Server-side apply StatefulSet and Services
zookeeper-operator-apply; fields owned by other managers are kept.csaupgrademoves ownership from the legacyzookeeper-operatormanager, so fields earlier versions rendered are removed when no longer requested. Migrating field ownership does not roll pods.Behavior changes
spec.labelsnow propagates to existing Services and the StatefulSet; Service selector is enforced.SyncStatefulSetreplaced the whole Pod template andSyncServicereplaced ports and annotations, so reconciliation reverted those edits. With server-side apply, a sidecar, environment variable, volume, or extra Service port added withkubectl editcan survive reconciliation if the operator doesn't own that field. This is intentional. If you relied on the operator to undo these edits, remove them explicitly. The operator still reconciles fields it renders.Steady-state API cost
resourceVersion, but still reach the API server and can incur admission and audit work. Skipping these requests is tracked in Skip no-op server-side apply requests during settled reconciles #121.Tests: unit + envtest (steady state settles, conflict retries, legacy adoption without rollout, legacy field removal).