feat: expose every recorded call on fake instances - #74
Merged
Conversation
allCalls() makes 'this action stayed local' testable. Asserting a specific route was never called can't fail when the client has no way to call it — a consumer's spec was doing exactly that — but comparing the recorded calls before and after an action checks the real claim.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allCalls()makes "this action stayed local" testable. Asserting a specific route was never called can't fail when the client has no way to call it — a consumer spec was doing exactly that, an unfalsifiable assertion that also pinned an otherwise provider-agnostic test to one provider. Comparing recorded calls before and after an action checks the real claim.