Repository navigation
Substrate bump to da35a983 (2026-10-13): HttpGetAction rename - #84
Merged
Merged
Conversation
Substrate main renamed the initialisms in the API proto (#2520): HTTPGetAction is HttpGetAction, and the three env call sites follow. Nothing else in the range touches what ate-env uses: the proto diff is the rename plus comment edits, the JSON field names are unchanged, and the ActorTemplate `ate-env manifest template` renders is byte-identical to the one rendered at f03327bd. README: the compatibility line names the new pin and says what the cluster has to accept (sandboxClasses, snapshotConfig, wakeupProbe) instead of requiring that exact revision, which the wire format does not.
|
|
||
| require ( | ||
| github.com/agent-substrate/substrate v0.4.1-0.20261013000135-f03327bd4aa8 | ||
| github.com/agent-substrate/substrate v0.4.1-0.20261013175625-da35a983ed34 |
Collaborator
There was a problem hiding this comment.
dependabot auto bump in the future?
Collaborator
Author
There was a problem hiding this comment.
Not for this module. #83 adds Dependabot for the Go module, the Python client and the workflow actions, and excludes github.com/agent-substrate/substrate on purpose: each bump of it changes the generated API that the manifests use. This PR is the example: a plain version bump does not compile until HTTPGetAction becomes HttpGetAction, and the rendered manifests must be compared before and after. That stays a hand-made PR: bump, fix the compile breaks, diff ate-env manifest template output against the previous pin, update the README compatibility line. Everything else in go.mod gets the weekly grouped Dependabot PR.
Collaborator
|
/lgtm |
Collaborator
Author
Sunny (sunnylovestiramisu)
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the Substrate pin from
f03327bd(2026-10-12, #77) to today'smain,da35a983. 13 upstream commits.What env needed
HTTPGetAction→HttpGetAction. Three call sites follow:cmd/ate-env/manifest.goand the two tests that build aWakeupProbe.ateapi.protodiff in the range is that rename (alsoHTTPRule/HTTPSRule/TLSPassthroughRule, which env does not use) plus comment edits. JSON field names are unchanged, so the manifests on the wire are the same.README
The compatibility line names the new pin. It now says what the cluster has to accept (
spec.sandboxClasses,snapshotConfig,wakeupProbe) instead of "at least that revision": the live cluster runs an older Substrate thanda35a983and takes these manifests, so the exact-revision wording was stricter than the truth.Verification
go build,go vet,go test ./...: 12 packages ok.make verify-gofmt verify-boilerplatepass. staticcheck reports only the three pre-existing ST1005 strings that Housekeeping: dependency bumps, lint debt, finished TODOs, dependabot #83 fixes.ate-env manifest template --guest-image … --snapshots-bucket …built from this branch is byte-identical to the render frommainatf03327bd(the one checked against the cluster in Bump Substrate to f03327bd: follow the current API and stop sending ate-target-actor twice #77).Overlap
go.sumalso moves in #83 (grpc/k8s/mcp bumps). Whichever lands second gets ago mod tidyrebase from me.