Skip to content

Substrate bump to da35a983 (2026-10-13): HttpGetAction rename - #84

Merged
Sunny (sunnylovestiramisu) merged 1 commit into
mainfrom
bump-substrate-2026-10-13
Oct 14, 2026
Merged

Sunny (sunnylovestiramisu) merged 1 commit into
mainfrom
bump-substrate-2026-10-13

Conversation

@tomergee

Copy link
Copy Markdown
Collaborator

Moves the Substrate pin from f03327bd (2026-10-12, #77) to today's main, da35a983. 13 upstream commits.

What env needed

  • substrate#2520 renames initialisms in the API proto: HTTPGetAction → HttpGetAction. Three call sites follow: cmd/ate-env/manifest.go and the two tests that build a WakeupProbe.
  • Nothing else. The ateapi.proto diff in the range is that rename (also HTTPRule/HTTPSRule/TLSPassthroughRule, which env does not use) plus comment edits. JSON field names are unchanged, so the manifests on the wire are the same.
  • Not relevant to env: atelet declarative validation (#1997), the objectstore-plugin rename (#2540; env does not reference the sidecar), health probes moving to :9091 (#2424), atenet→atunnel CONNECT (#2531).

README

The compatibility line names the new pin. It now says what the cluster has to accept (spec.sandboxClasses, snapshotConfig, wakeupProbe) instead of "at least that revision": the live cluster runs an older Substrate than da35a983 and takes these manifests, so the exact-revision wording was stricter than the truth.

Verification

Overlap

go.sum also moves in #83 (grpc/k8s/mcp bumps). Whichever lands second gets a go mod tidy rebase from me.

Substrate main renamed the initialisms in the API proto (#2520):
HTTPGetAction is HttpGetAction, and the three env call sites follow.
Nothing else in the range touches what ate-env uses: the proto diff is the
rename plus comment edits, the JSON field names are unchanged, and the
ActorTemplate `ate-env manifest template` renders is byte-identical to
the one rendered at f03327bd.

README: the compatibility line names the new pin and says what the
cluster has to accept (sandboxClasses, snapshotConfig, wakeupProbe)
instead of requiring that exact revision, which the wire format does not.
Comment thread go.mod

require (
github.com/agent-substrate/substrate v0.4.1-0.20261013000135-f03327bd4aa8
github.com/agent-substrate/substrate v0.4.1-0.20261013175625-da35a983ed34

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependabot auto bump in the future?

@tomergee Tomer Glottmann (tomergee) Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this module. #83 adds Dependabot for the Go module, the Python client and the workflow actions, and excludes github.com/agent-substrate/substrate on purpose: each bump of it changes the generated API that the manifests use. This PR is the example: a plain version bump does not compile until HTTPGetAction becomes HttpGetAction, and the rendered manifests must be compared before and after. That stays a hand-made PR: bump, fix the compile breaks, diff ate-env manifest template output against the previous pin, update the README compatibility line. Everything else in go.mod gets the weekly grouped Dependabot PR.

@sunnylovestiramisu

Copy link
Copy Markdown
Collaborator

/lgtm

@tomergee

Copy link
Copy Markdown
Collaborator Author

Thanks! One more click, please: this repo has no Prow, so /lgtm does not count. The ruleset on main needs one review submitted as Approve (Files changed → Review changes → Approve), and I cannot approve my own PR. Same for #83 and #82 if you have a minute; all three are green and merge clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants