Repository navigation
ci: bump actions/setup-go to v7.0.0 for Node.js 24 runner support - #85
Merged
Tomer Glottmann (tomergee) merged 1 commit intoOct 13, 2026
Conversation
Sunny (sunnylovestiramisu)
requested a review
from Tomer Glottmann (tomergee)
October 13, 2026 22:12
Tomer Glottmann (tomergee)
requested changes
Oct 13, 2026
Tomer Glottmann (tomergee)
left a comment
Collaborator
There was a problem hiding this comment.
The bump is correct and safe. The description is wrong about what it fixes. Two changes before merge.
Blocking: none.
Before merge
- PR description. The #80 presubmit did not fail because of Node.js 20. The Node.js 20 message is a warning; the action ran on Node.js 24 and the step passed. The job failed at
hack/verify/boilerplate.sh: five files in #80 have no license header (clients/python/src/ate_env/backend/__init__.py,clients/python/tests/test_config.py,test_exec_semantics.py,test_fleet_strategies.py,test_fleet_types.py). This PR does not make #80 green. Rewrite the first paragraph: this PR removes the deprecation warning. Add the headers in #80. .github/workflows/ci.yaml:58.actions/setup-python@a26af69…(v5.6.0) also runs on Node.js 20. The same warning shows on the Python job of this PR's own run (38473102364). Bump it in this PR:actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7.0.0(tag verified,runs.using: node24). After that, no action in the two workflows targets Node.js 20: checkout v5.1.0 is node24, setup-ko and cosign-installer are composite.
Verified, no action needed
b7ad1dad…is thev7.0.0tag and also thev7major tag;runs.using: node24.- v7.0.0 has the inputs
go-version-fileandcache; both call sites are drop-in. - v6.0.0 changed toolchain selection (actions/setup-go#460).
go.modhasgo 1.27.0and notoolchainline, thus the installed Go stays 1.27.0. The Go job on this PR passed. - v7.0.0 itself is the ESM migration plus
@actions/cache6.2.0; no input changes.
Nit
- Body, "Testing":
go testand the verify scripts do not test a workflow change. Name this PR's CI run and the missing warning on the Go job instead.
…pport GitHub Actions runners are deprecating Node.js 20 and forcing actions targeting Node.js 20 onto Node.js 24, which causes presubmit workflows using actions/setup-go@v5.6.0 and actions/setup-python@v5.6.0 to warn or fail with exit code 1. - Bump actions/setup-go to v7.0.0 (commit b7ad1dad31e06c5925ef5d2fc7ad053ef454303e) in ci.yaml and release.yaml. - Bump actions/setup-python to v7.0.0 (commit 5fda3b95a4ea91299a34e894583c3862153e4b97) in ci.yaml. Both v7.0.0 actions run natively on Node.js 24 while maintaining exact input/output compatibility.
Sunny (sunnylovestiramisu)
force-pushed
the
fix/bump-setup-go-node24
branch
from
October 13, 2026 22:55
64932f9 to
cf5a83f
Compare
Tomer Glottmann (tomergee)
approved these changes
Oct 13, 2026
Tomer Glottmann (tomergee)
left a comment
Collaborator
There was a problem hiding this comment.
Both points addressed: the description now says what the PR does, and setup-python is on the verified v7.0.0 pin. CI run 38481020510 has no Node.js 20 warning on either job.
Tomer Glottmann (tomergee)
merged commit Oct 13, 2026
6db127c
into
agent-substrate:main
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR bumps
actions/setup-goandactions/setup-pythontov7.0.0across the CI and release workflows, removing runner deprecation warnings for Node.js 20.GitHub Actions runners are deprecating the Node.js 20 execution runtime and forcing actions targeting Node.js 20 onto Node.js 24. While existing workflows are temporarily forced to run under Node.js 24 with deprecation warnings, bumping both actions to
v7.0.0moves them onto native Node.js 24 execution and eliminates all runner deprecation warnings:.github/workflows/ci.yaml:actions/setup-gobumped fromv5.6.0(40f1582b2485089dde7abd97c1529aa768e1baff) tov7.0.0(b7ad1dad31e06c5925ef5d2fc7ad053ef454303e).actions/setup-pythonbumped fromv5.6.0(a26af69be951a213d495a4c3e4e4022e16d87065) tov7.0.0(5fda3b95a4ea91299a34e894583c3862153e4b97)..github/workflows/release.yaml:actions/setup-gobumped fromv5.6.0(40f1582b2485089dde7abd97c1529aa768e1baff) tov7.0.0(b7ad1dad31e06c5925ef5d2fc7ad053ef454303e).With these updates, no actions in
ci.yamlorrelease.yamltarget Node.js 20 (actions/checkoutis already onv5.1.0which runs on Node.js 24, andsetup-ko/cosign-installerare composite actions). Bothv7.0.0actions maintain drop-in compatibility for all inputs, outputs, and caching behaviors.Testing
make verify-gofmtpassed.hack/verify/boilerplate.shpassed.go test -count=1 ./...passed.