You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We recently switched all ate-apiserver RPC validations to use k8s Declarative Validations. The atelet and ateom APIs are still using hard-written validations. This task is to switch to DV and remove the hard-written ones.
Something to consider is that atelet and ateom RPC APIs use oneofs, which are not supported by DV. This means that we need breaking changes in both APIs before onboarding DV. Tim Hockin (@thockin)
Another issue: the atelet API seems to be importing pkg/proto/ateapipb/ateapi.proto just to re-use WorkerResources. I don't think we should reuse API messages across API boundaries. It's also inconsistent with other methods that have their own messages. We should make atelet have it's own version of the message and have a converter that converts back and forth (like other messages, e.g. WorkloadSpec.
Activity
juli4n commentedon Sep 17, 2026
Something to consider is that atelet and ateom RPC APIs use oneofs, which are not supported by DV. This means that we need breaking changes in both APIs before onboarding DV. Tim Hockin (@thockin)
thockin commentedon Sep 17, 2026
Do it now or do it never?
juli4n commentedon Sep 29, 2026
Another issue: the atelet API seems to be importing
pkg/proto/ateapipb/ateapi.protojust to re-useWorkerResources. I don't think we should reuse API messages across API boundaries. It's also inconsistent with other methods that have their own messages. We should make atelet have it's own version of the message and have a converter that converts back and forth (like other messages, e.g.WorkloadSpec.atelet: introduce declarative validation for the AteomSupport RPCs (a…
atelet: introduce declarative validation for the AteomHerder RPCs (ag…
Consolidate API validation for sandbox class across services (agent-s…
ateworker: introduce declarative validation for the Ateworker RPCs (a…