Skip to content

Switch atelet / ateom RPC validations to DV #1709

Closed

Description

We recently switched all ate-apiserver RPC validations to use k8s Declarative Validations. The atelet and ateom APIs are still using hard-written validations. This task is to switch to DV and remove the hard-written ones.

Activity

  1. juli4n commented on Sep 17, 2026

    @juli4n
    CollaboratorAuthor

    Something to consider is that atelet and ateom RPC APIs use oneofs, which are not supported by DV. This means that we need breaking changes in both APIs before onboarding DV. Tim Hockin (@thockin)

  2. thockin commented on Sep 17, 2026

    @thockin
    Collaborator

    Do it now or do it never?

  3. juli4n commented on Sep 29, 2026

    @juli4n
    CollaboratorAuthor

    Another issue: the atelet API seems to be importing pkg/proto/ateapipb/ateapi.proto just to re-use WorkerResources. I don't think we should reuse API messages across API boundaries. It's also inconsistent with other methods that have their own messages. We should make atelet have it's own version of the message and have a converter that converts back and forth (like other messages, e.g. WorkloadSpec.

  4. added a commit that references this issue on Oct 17, 2026
    5e9846c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions