Create Actor should treat golden snapshot as any other source_tag #2210

Activity

1. Zoe Zhao (zoez7)

   added this to the M3 milestone on Oct 5, 2026
2. Zoe Zhao (zoez7)

   added the

   Task

   issue type on Oct 5, 2026
3. Zoe Zhao (zoez7)

   added

   area/api-machinery

   on Oct 5, 2026
4. Zoe Zhao (zoez7)

   added a parent issue on Oct 5, 2026

   • Actor Lifecycle API changes for GA #2069
5. Aditya Shantanu (aditya-shantanu)

   added

   kind/bugSomething isn't working / bugfixesSomething isn't working / bugfixes

   area/apiUser-facing API changesUser-facing API changes

   on Oct 5, 2026
6. cloudonly commented on Oct 7, 2026

   

   Luomu (cloudonly)

   on Oct 7, 2026

   Last edited by cloudonly

   Contributor

   More actions

   Implemented the creation-time stamp in #2290. The latest commit is 5be99d8a.

   When the caller omits source_tag, CreateActor records the template's golden tag in the stored Actor. It applies the default to a copy of the request. The new regression assertion checks that successful and rejected requests both remain unchanged. Explicit source tags and golden snapshot scope validation keep their existing behavior.

   Whole-object UpdateActor requests must retain the recorded source_tag under the existing immutability rule.

   The PR records the snapshot source only. Resuming after template deletion still needs separate work: loadActorForResume resolves the template, and template deletion also deletes the golden tag and releases its snapshot. A source_tag fallback alone would not preserve that snapshot. The PR now uses Refs #2210 so this remaining lifecycle problem is not automatically closed.

   Validated on Linux/amd64 with Go 1.27.1, PostgreSQL 18 testcontainers and Kubernetes envtest, with REQUIRE_DOCKER=1:

   • Both controlapi test packages passed with the race detector: 326 top-level tests, zero failures or skips. All seven golden-tag scenarios and six changed functional tests executed.
   • Removing the request copy in a temporary variant made all six default-tag cases fail the new immutability assertion. The original implementation was restored before the passing run.
   • All 14 static verifiers passed. Project-wide make verify passed 137 packages and failed two packages with filecache write-protection and imagecache OverlayFS errors on this root/Linux 5.14 host. The same failures reproduced at merge base 3230f9f8.
7. Zoe Zhao (zoez7)

   removed a parent issue on Oct 18, 2026

   • Actor Lifecycle API changes for GA #2069