You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Get and Delete request messages for singleton subresources should take a name field. #2363
In #2354 , in Section #2.4 of the style guide we say that Get and Delete requests for a resource should carry a name field holding the sub-resource name. For a singleton sub-resource that name must be default. Today we have EgressPolicy (Actor), AccessPolicy (Atespace) and AccessPolicy (Global) as singleton subresources. Neither of them have it.
This is inconsistent with Create, where clients must already set metadata.name to default. The same resource should be named the same way on every method. It also means singleton subresources use different request shape from other subresources, which makes the style guide confusing.
Proposed change
Add a name field to each Get<Parent><Resource>Request and Delete<Parent><Resource>Request> message.
Reject any value other than default with INVALID_ARGUMENT (we already have a custom validator).
Activity
juli4n commentedon Oct 8, 2026
FYI Tim Hockin (@thockin)
Singleton subresource Get and Delete requests take a name (agent-subs…