Skip to content

api: rename MintActorJWTRequest.audience to plural audiences #2408

Closed

Description

Background

In pkg/proto/ateapipb/ateapi.proto, MintActorJWTRequest (ateapi.proto:1716) defines a repeated field using a singular noun:

message MintActorJWTRequest {
  ObjectRef actor = 5;

  // The audiences the minted JWT is bound to. Tokens are only issued with
  // audience bindings, so at least one is required.
  repeated string audience = 1;

  int64 expiration_seconds = 8;
}

This violates docs/api-style-guide.md §5 ("Repeated fields must use the plural noun form") and is inconsistent with ActorJWTSource (ateapi.proto:680), which names the same repeated field audiences:

message ActorJWTSource {
  repeated string audiences = 1;
  int64 expiration_seconds = 2;
}

Proposed Changes

  1. pkg/proto/ateapipb/ateapi.proto:
    • Rename MintActorJWTRequest.audience -> audiences.
  2. Regenerate & update callers:
    • Run hack/update/codegen.sh to regenerate pkg/proto/ateapipb/ateapi.pb.go and declarative validation in cmd/ateapi/internal/apivalidation.
    • Update callers and tests in cmd/ateapi/, cmd/atenet/internal/router/egress/actorjwt/, and docs/.

Taahir Ahmed (@ahmedtd)

Activity

  1. added a commit that references this issue on Oct 9, 2026
    55b6e00
  2. added a commit that references this issue on Oct 14, 2026
    70a792c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

area/apiUser-facing API changeskind/cleanupSmall fixes that are not bugs, for example a typo in a code comment

Type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions