Skip to content

Remove oneofs from ate-apiserver API #962

Closed
Task
Closed
Remove oneofs from ate-apiserver API#962
Task
Labels
area/apiUser-facing API changesarea/api-machinerykind/cleanupSmall fixes that are not bugs, for example a typo in a code comment

Description

@juli4n
Julian Gutierrez Oschmann (juli4n)
opened on Aug 14, 2026

We plan to use k8s declarative validation framework for validating requests in the Substrate API. The DV framework doesn't play well with proto oneofs so we need to avoid them for discriminated unions.

Oneof can be just replaced with two message-type fields (for each option) plus an optional string discriminator field.

Today we use oneof in a couple of places:

  • EnvVar source (only one value: string).
  • Volume source (durable dir or external volume template).

Activity

  1. Julian Gutierrez Oschmann (juli4n)
    added
    area/apiUser-facing API changes
    on Aug 14, 2026
  2. Julian Gutierrez Oschmann (juli4n)
    added the
    Task
    issue type on Aug 14, 2026
  3. Julian Gutierrez Oschmann (juli4n)
    added
    area/api-machinery
    on Aug 14, 2026
  4. Julian Gutierrez Oschmann (juli4n)
    assigned
    Tim Hockin (thockin)
    and unassigned
    Tim Hockin (thockin)
    on Aug 15, 2026
  5. Aditya Shantanu (aditya-shantanu)
    added
    kind/cleanupSmall fixes that are not bugs, for example a typo in a code comment
    on Aug 17, 2026
  6. Julian Gutierrez Oschmann (juli4n)
    added a commit that references this issue on Aug 18, 2026

    Update ActorTemplate substrate resource definition per latest discuss…

    9edf65f
  7. Julian Gutierrez Oschmann (juli4n)
    added a parent issue on Aug 24, 2026
  8. github-project-automation
    added this to Substrate Milestones (go/substrate-milestones)on Aug 24, 2026
  9. github-project-automation
    moved this to Todo in Substrate Milestones (go/substrate-milestones)on Aug 24, 2026
  10. Max Thompson (thompsonmax)
    added 2 commits that reference this issue on Aug 26, 2026

    Mirror systemInfo volumes into the ActorTemplate substrate resource

    86ff111

    Mirror systemInfo volumes into the ActorTemplate substrate resource

    0657203
  11. Zoe Zhao (zoez7)
    added a commit that references this issue on Aug 26, 2026

    Mirror systemInfo volumes into the ActorTemplate substrate resource (#…

    843ca20

  12. juli4n commented on Aug 27, 2026

    @juli4n
    Julian Gutierrez Oschmann (juli4n)
    on Aug 27, 2026
    CollaboratorAuthor

    There are no oneofs in the API service messages now. Additionally, after #1274 presubmit checks will fail if an oneof field added.

  13. Julian Gutierrez Oschmann (juli4n)
    closed this as completedon Aug 27, 2026
  14. github-project-automation
    moved this from Todo to Done in Substrate Milestones (go/substrate-milestones)on Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/apiUser-facing API changesarea/api-machinerykind/cleanupSmall fixes that are not bugs, for example a typo in a code comment

    Type

    Task

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions