Repository navigation
benchmarking: add OOM kills to server telemetry - #2391
Merged
Max Smythe (maxsmythe) merged 1 commit intoOct 17, 2026
Merged
Conversation
Contributor
Author
|
cc Haowei Cai (Roy) (@roycaihw), Max Smythe (@maxsmythe) - ptal:) |
Nishanth Kotla (Nishanth29)
force-pushed
the
oom-events
branch
from
October 9, 2026 05:03
08cdc02 to
24368cd
Compare
Contributor
Author
|
Da Huang (@git286) Tim Bai (@baizhenyu), adding you as reviewers. What this uses:
If you'd rather add an actor OOM-kill counter in Substrate (e.g. from the |
Collaborator
Nishanth Kotla (Nishanth29)
force-pushed
the
oom-events
branch
2 times, most recently
from
October 14, 2026 18:57
517f1aa to
10cada2
Compare
Haowei Cai (Roy) (roycaihw)
left a comment
Contributor
There was a problem hiding this comment.
See my comment in #2386 (comment). Let's address the naming and get #2386 merged first. LGTM otherwise.
Nishanth Kotla (Nishanth29)
force-pushed
the
oom-events
branch
from
October 16, 2026 03:13
10cada2 to
362555e
Compare
Contributor
Author
|
Haowei Cai (Roy) (@roycaihw) Rebased onto the updated #2386 branch and updated |
Nishanth Kotla (Nishanth29)
requested a review
from Haowei Cai (Roy) (roycaihw)
October 16, 2026 03:19
Nishanth Kotla (Nishanth29)
force-pushed
the
oom-events
branch
from
October 17, 2026 01:16
362555e to
1edd596
Compare
Max Smythe (maxsmythe)
enabled auto-merge
October 17, 2026 01:25
auto-merge was automatically disabled
October 17, 2026 02:13
Head branch was pushed to by a user without write access
Nishanth Kotla (Nishanth29)
force-pushed
the
oom-events
branch
from
October 17, 2026 02:13
1edd596 to
d2b8e73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1590
Adds an
oom_eventsblock to server telemetry:node,pod: OOM kills over the run, from cAdvisor'scontainer_oom_events_total.nodecounts global OOMs.podcounts kills inside a worker pod (actor sandboxes and theworkercontainer) and is best effort: a kill whose cgroup is gone before the scrape is missed.worker_restarts,worker_oomkilled_pods,evicted,worker_pods_lost: from the Kubernetes API, read before and after the run.evictedcomes fromEvictedevents, asatecontrollerdeletes an evicted pod at once.Other changes:
monitoring.yamlkeepscontainer_oom_events_total.benchmark-workloadsRole can also list events.Live check (gVisor, 3m):
Actor limit 256Mi, 2 users:
pod = 6, matching 6 kerneloom-killlines, one per actor sandbox. Other fields 0; the worker stayed up.No actor limit, 8 users: the kernel killed the whole worker twice at the node-allocatable limit (
oom_memcg=/kubepods.slice), and the kubelet evicted it.evicted = 7(1 eviction plus 6 replacement pods the kubelet refused to start),worker_pods_lost = 1,node = pod = 0, as documented.80 measurements in the jsonl row.
Tests pass
Appropriate changes to documentation are included in the PR