Repository navigation
Validate mounted volumes for VOLUMES snapshots - #2550
Closed
Luomu (cloudonly) wants to merge 1 commit into
Closed
Luomu (cloudonly) wants to merge 1 commit into
Luomu (cloudonly) wants to merge 1 commit into
Conversation
This was referenced Oct 13, 2026
Contributor
Author
|
Closing in favor of #1972, which implements the same admission rule for #1936 and carries the issue link, a fuller validation matrix (including image volumes and unmounted CSI volumes), and the custom-validation doc updates. The user documentation from this PR now lives in #1972, placed beside the ROOTFS rule in the template spec table. #2543 now stacks on #1972. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VOLUMES checkpoints require a volume mounted by a container that the selected runtime can capture. Templates without one were accepted by the API and failed only when a checkpoint was attempted.
Validate this at template creation: both runtimes accept mounted durable-dir volumes, and micro-VM also accepts mounted external volumes. Declared but unmounted volumes and CSI-only gVisor templates are rejected with InvalidArgument. This applies whether Golden snapshots are enabled or disabled.
Adds validation regressions, fixes the existing VOLUMES functional-test fixture to mount its durable data, and documents the requirement. This is an independent prerequisite for #2543; it does not change Golden placement or public request schemas.
Validation
Validated
a78f8e22on Linux/amd64 with Go 1.27.1:go test -race -count=1 ./...passed, including the complete functional suite with PostgreSQL and Kubernetes envtest.hack/verify-all.shpassed all 15 verifiers. The initial lint package load exceeded its existing timeout; a rerun after package-cache warmup passed without changing the timeout or checks.go test -race -count=1 ./...passed intools/apitool.The invalid-template regressions were observed failing before the validation change. Functional tests use PostgreSQL and Kubernetes envtest with a fake atelet; real gVisor/micro-VM E2E was not run.
AI assistance: Codex helped implement, review, and validate this change.