Repository navigation
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
2 tasks done
hajiler
force-pushed
the
api/external-volume-source
branch
from
October 14, 2026 18:07
ec502b6 to
64e3351
Compare
hajiler
force-pushed
the
api/external-volume-source
branch
from
October 14, 2026 18:49
64e3351 to
580a413
Compare
hajiler
force-pushed
the
api/external-volume-source
branch
from
October 15, 2026 18:02
580a413 to
a83aea3
Compare
hajiler
force-pushed
the
api/external-volume-source
branch
2 times, most recently
from
October 16, 2026 18:13
4a9c50e to
cfa2183
Compare
hajiler
force-pushed
the
api/external-volume-source
branch
from
October 16, 2026 20:54
cfa2183 to
6b3279c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2407, #2436.
What changes
One rename in the volume API, split out of #2567 so the breaking part lands before GA and the shared-volume feature can follow as a non-breaking addition.
Volume.external_volume_templatebecomesVolume.external, typedExternalVolumeSource, with the existingExternalVolumeTemplateunder itstemplatemember. The field name now matches its siblings (durable_dir,system_info,image) and the message follows the*VolumeSourceconvention (#2407, #2436). TheExternalVolumespreview gate moves onto the new member, so gating behaviour is unchanged.ExternalVolumeSourceis a union with one member today; the shared-volume reference is added as a second member in #2567.The per-actor record in ActorStatus gets wrapped in a new ExternalVolumes message. This will make changes for shared volume support easier post GA.
Callers, tests, demos, benchmark manifests and docs are updated; generated code is regenerated.
Testing
Unit, store (Postgres), controlapi and functional suites pass;
hack/verify/gofmt.sh,hack/verify/boilerplate.sh,apitool validateand its exemption test pass.Breaking change
ActorTemplate.volumes[].externalVolumeTemplateis gone; templates must usevolumes[].external.template. Field number 3 is retired, not reused, so templates stored under the old field decode with no volume source and must be recreated (they fail validation on their next update). Go consumers ofpkg/proto/ateapipbsee the newExternalVolumeSourcetype and the moved getter.Requesting the
breaking-changelabel.🤖 Generated with Claude Code