Repository navigation
ateworker internal packages cleanup - #2700
Merged
Tim Hockin (thockin) merged 16 commits intoOct 15, 2026
Merged
Conversation
atecontroller only needs these, not the rest of the worker registration code
it's a generic named netns helper, and atunnel's tests use it
atelet imports it for StatsSourceLabel
Benjamin Elder (BenTheElder)
added
kind/cleanup
2 tasks done
leaves internal/ateworker for the shared worker code
Tim Hockin (thockin)
approved these changes
Oct 15, 2026
Collaborator
There was a problem hiding this comment.
minor: Why internal/... and not cmd/atecontroller/internal/... ?
Collaborator
Author
There was a problem hiding this comment.
It's used by both atecontroller (to set the downward API) and internal/ateworker/register (to read the downward API), so they agree on paths and keys.
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2254, renames the remaining internal/ateom* go packages.
After this change there is no
ateomleft in the repo. 🫡internal/ateworker: register (the registration code, leavinginternal/ateworkeritself for the shared worker code), cgroup, pid1 (was ateominit), actornet (was ateomnet), phaselog, suspend, tunnelinternal/workerstats, which atelet also imports, andinternal/netns, a generic named netns helper that atunnel's tests also useinternal/workercapacity, so it doesn't import the worker registration codedepguard(golangci-lint) now fails any import ofinternal/ateworkeroutsidecmd/ateworker-*andinternal/ateworkerThe move commits are only
git mv, imports and package names are fixed in a separate commit after each round of moves, to make it clear which changes are just file moves and which changes are import rewrites etc.We squash merge, so the intermediate commits don't need to build.
This PR was AI assisted. I have reviewed the changes.