Repository navigation
docs: fix typos in RULER workflows and file reader docstring - #642
Open
Avicennasis wants to merge 1 commit into
Open
Avicennasis wants to merge 1 commit into
Avicennasis wants to merge 1 commit into
Conversation
- math_ruler_workflow.py: 'whereasa' -> 'whereas' in the reset() docstring. - math_ruler_workflow.py, math_trainable_ruler_workflow.py: 'first think ... and then provides the final answer' -> 'provide' in the RULER judge prompt (the same sentence in both workflows). - file_reader.py: 'Filed based' -> 'File-based' in the module docstring. Signed-off-by: Léon Avic Simmons <Avicennasis@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Three small typo fixes:
trinity/common/workflows/math_ruler_workflow.py:whereasa->whereasin thereset()docstring.trinity/common/workflows/math_ruler_workflow.pyandtrinity/common/workflows/math_trainable_ruler_workflow.py: the RULER judge prompt says "first think about the reasoning process in the mind and then provides the final answer". Changedprovides->provideto agree with the imperative "think". The sentence is identical in both workflows, so both were changed.trinity/buffer/reader/file_reader.py: module docstringFiled based->File-based.The
providefix changes one word of the judge prompt string, so it is not purely a comment change.MAX_TOKEN_LENGTH = 8196inexamples/mix_chord/get_openr1_data.pywas deliberately left unchanged. It may have been meant as 8192, but changing it would change which samples are filtered, so I've left that call to you.Checklist