Repository navigation
Install the CI lint tools; update devenv to 0.2.9 - #975
Merged
Merged
Conversation
Pre-existing on develop, where pushes do not run CI: eslint-plugin-unicorn prefer-ternary and no-immediate-mutation in three frontend files, and ruff ICN001 (`import datetime as dt`) in four Python files. Behavior unchanged; `make lint` could not reach the shell, Dockerfile and workflow checks until these passed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
devenv 0.2.9 makes a missing lint tool an error in CI instead of a skip, so the codex-ci stage now copies shellcheck, shfmt, hadolint, actionlint and dockerfmt from their upstream images and unpacks shellharden's latest release, as devenv's README prescribes. apt's shellcheck goes, so the image runs the same version as the dev machines. The devenv update brings the `need` guard in bin/_lib.sh, forwards CI into the compose service, and adds the devenv-lint-tools action and the native-mode install step. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
uv's sdist builder reads docs/NEWS/codex and docs/img, symlinks to directories, as files and fails with "Is a directory". Pre-existing on develop, where pushes do not run CI; it broke the Build Dist job. The site builds from the checkout, so the sdist does not need them. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex-cistage:COPY --fromthe upstream images for shellcheck, shfmt, hadolint, actionlint and dockerfmt, plus shellharden's latest release tarball. Drops apt's shellcheck so the image's version matches the dev machines.make update-devenvto devenv 0.2.9:needinbin/_lib.shfails in CI when a tool is missing,compose.yamlforwards the runner'sCIinto the container, and thedevenv-lint-toolsaction lands for native mode.datetimealiases); without themmake lintnever reached the shell, Dockerfile and workflow checks.docs/NEWS/codex,docs/img) from the sdist: uv's builder reads them as files and the Build Dist job failed with "Is a directory". Also pre-existing on develop.The branch carries a
v0prefix sodevenv-checkruns on this pull request into develop.Known: the Lint job fails at its last step,
actionlint, until devenv'slint-ci.shpasses the workflow files explicitly (actionlint cannot find a project in the CI image, which has no.git). A follow-upmake update-devenvcommit lands here once that fix is on devenv main.Test plan
make fix lint testlocally: lint runs all six tools with noskipped:line, 1668 tests passuv build --sdistand--wheelsucceed locallyskipped:line and nonot installederror🤖 Generated with Claude Code