Repository navigation
Adapt to comicbox 5.3.2 - #977
Merged
Merged
Conversation
comicbox 5.3.2 (pinned in c36f194) needs no code changes here, only accurate comments and the user-facing fixes it brings in NEWS: - Renames strip ":" and the other characters Windows and SMB shares can't store. Codex has no filename sanitizing of its own to retire. - MetronOnlineSource now sends mokkari the API token alone when one is set, so a leftover username & password never reaches mokkari, and mokkari 4.10 stops ~/.netrc replacing the Bearer token. Codex still hands comicbox all three fields, so comments that said "mokkari prefers the token" now say comicbox sends only the token. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
comicbox 5.3.2 was already pinned and locked in
c36f194c9 update deps, and codex runs on it unchanged. This PR corrects comments that described the old behaviour and adds NEWS for the two user-facing fixes the bump brings in.What 5.3.2 changes for codex
:and"*<>?|, not only path separators, so tag-write renames produce names that Windows and SMB shares can store. Codex has no sanitising of its own to retire.MetronOnlineSourcenow gives mokkari only the API token when one is set, and mokkari 4.10 stops~/.netrcfrom replacing the Bearer token. Codex still passes comicbox all three credential fields, which is fine. comicbox picks the token, not mokkari.Changes
codex/models/admin.py,codex/serializers/admin/tagging.py: comments that said "mokkari prefers the token" now say comicbox sends only the token.tests/test_credential_validator.py: docstring updated to match. The assertion is unchanged: codex still hands comicbox all three fields.NEWS.md(v2.5.5 Fixes): renamed comics no longer contain characters Windows/SMB can't store; a Metron API key is no longer overridden by a~/.netrclogin.Test plan
make fix: no changes beyond this diffmake lint: passesmake test: 1668 pytest passed, 1 xfailed; 994 vitest tests across 97 files passedDeprecationWarnings raised as errors🤖 Generated with Claude Code