Repository navigation
Remove the four pinned settings from the schema - #981
Merged
Merged
Conversation
#910 pinned dynamic covers, custom covers and finish-on-last-page on and read-RTL-in-reverse off, and removed their checkboxes, but kept the columns, serializer fields, defaults, telemetry buckets and sidecar export so the toggles could come back with a revert. Nobody needs them back, so they go: - Migration 0057 drops SettingsBrowser.custom_covers/dynamic_covers and SettingsReader.finish_on_last_page/read_rtl_in_reverse. They shipped in 0038, so this is a real RemoveField migration, not a fold edit. - BROWSER_DEFAULTS/READER_DEFAULTS, the browser, reader and session serializers, the telemetry and admin stats buckets, and the user-data sidecar schema/dump/restore lose the keys. The sidecar SCHEMA_VERSION is unchanged: the store only adds columns and restore reads named columns, so a pre-removal sidecar still restores (the legacy restore fixture keeps the two keys as the regression guard). - Dead code the pin left behind goes too: the sort-name fuzzy cover match and parent_route, the custom-cover early return, the unused BrowserCoverInputSerializer, the coverSettings getter and its key lists, setReadRTLInReverse, and the parked browser-settings-covers component. BrowserCoverInputSerializerBase folds into BrowserSettingsSerializerBase, and get_reader_defaults now iterates READER_DEFAULTS. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#910 pinned dynamic covers, custom covers and finish-on-last-page on, and read-RTL-in-reverse off. It kept their columns so the toggles could come back with a revert. This PR removes them for good.
SettingsBrowser.custom_covers/dynamic_coversandSettingsReader.finish_on_last_page/read_rtl_in_reversewith fourRemoveFieldops. All four shipped in 0038, so this has to be a new migration, not an edit to an old one. It is reversible: the browser columns have defaults and the reader columns are nullable. Historical migrations are untouched.BROWSER_DEFAULTS/READER_DEFAULTS, the reader, browser and session-defaults serializers, andget_reader_defaults(which now iteratesREADER_DEFAULTS).BrowserCoverInputSerializerBaseis folded intoBrowserSettingsSerializerBase.SCHEMA_VERSIONis unchanged because the store only adds columns and restore reads named columns. The legacy_browser_rowrestore fixture keeps both keys as a regression guard for restoring an old sidecar.parent_routeincover.py, plus the custom-cover early return;BrowserCoverInputSerializer;coverSettingsgetter andCOVER_KEYS/DYNAMIC_COVER_KEYS;setReadRTLInReverse;browser-settings-covers.vue;PENDING SCHEMA REMOVALnote.Test plan
make fix,make lint,make ty: all cleanmake test: backend 1683 passed, 1 xfailed; frontend 994 passed (97 files)manage.py makemigrations --check --dry-run: no changesPENDING SCHEMA REMOVAL,parent_routeandparentRoute: the only hits are 0038, 0057, the legacy restore fixture, and identifiers of the separate CustomCover upload featuremigrateapplies 0057, andmigrate codex 0056reverses itChronicle still charts
dynamic_coversand tolerates the missing keys. Retiring that panel is a follow-up in that repo.🤖 Generated with Claude Code