Repository navigation
Show series and issue detail under each match candidate - #983
Merged
Merged
Conversation
Online-tag candidates often share a near-identical cover and an
identical title ("Batman #1 (2016)"): a reprint volume, a foreign or a
collected edition. comicbox 5.4 carries what tells them apart, and the
dialog now shows it in two subdued lines under the title:
DC Comics · Limited Series · Series began 2016 · 6 issues
"I Am Gotham, Part One" — <deck, clamped to two lines>
serialize_candidate passes the six new summary fields through by name,
so an older comicbox and prompts cached before them degrade to absent
fields. PROMPT_VERSION is unchanged; it gates fingerprints, not payload
shape. The serializer test uses a stand-in summary because the pinned
comicbox predates the fields.
The publisher moves off the title line into the detail line
(series_publisher, falling back to the scored publisher, which neither
source fills today). The score chip and Pick button no longer shrink,
so long detail text wraps instead of clipping them.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
At phone width a candidate row held a 48px cover, the text, the score chip and the Pick button side by side, leaving the text about 100px: series titles wrapped a word per line and the new series and issue detail lines showed a few words each. The chip and Pick now sit in one non-shrinking group. Below Vuetify's sm breakpoint the row wraps and that group takes its own right-aligned line, while the text, given a zero flex basis, keeps the cover's line and its full width. Wider layouts are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The issue title/deck line and the "Cover not compared" / score breakdown line drop from 0.8125rem to 0.75rem, the smallest size codex already uses. They are the least needed text in a candidate row; the series line and a.k.a. names keep 0.8125rem. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Online-tag match candidates often have near-identical covers and identical titles ("Batman #1 (2016)"), so picking between them was guesswork. They are usually the same issue in a reprint volume, a foreign edition or a collected edition.
What
Two subdued lines under each candidate's title:
DC Comics · Limited Series · Series began 2016 · 6 issues"I Am Gotham, Part One" — <deck>, clamped to two lines with the full text as a tooltip.Either line is omitted when empty. The data comes from Show what tells identical-looking match candidates apart comicbox#245.
Serializer:
serialize_candidatepasses the six new summary fields through withgetattr, so codex works against the pinned comicbox 5.3.2 (the lines just don't appear) and can merge before comicbox publishes.PROMPT_VERSIONis unchanged.Publisher: moves off the title line into the detail line (
series_publisher, falling back topublisher).Phones: the score chip and Pick button wrap to their own line, so the text gets the row's width instead of about 100px. Desktop layout is unchanged.
Text size: the deck line and the "Cover not compared" line drop to 0.75rem.
Verification
make fix,make lintandmake tyare clean. pytest: 1684 passed. vitest: 1003 passed after rebasing onto develop.Follow-up
After comicbox 5.4.0 publishes: bump the comicbox pin and add the NEWS line.
🤖 Generated with Claude Code