Repository navigation
Series facts line in the metadata header; Tags button on the browser title - #985
Merged
Merged
Conversation
The first cut of the series fields put the series year range and status inline in the xx-large series row, beside the volume's own parenthesised year, where they read like part of the name. The series row now names things only, and a subdued facts line under it carries the run (1963–1996, 1963–, –1996 or 1963) and the status, joined by a middle dot. The series summary is labelled "Series Summary" so it still reads right in a series' own pane, where the comic summary is usually empty. The browser title appends the same year range on a series page, from two new nullable title fields (collection_start_year/_end_year). A plain Tags button at the title bar's right edge opens the browsed collection's own metadata, like the one on browser cards; the root listing has none. It is positioned absolutely so the title stays centred, and the title gets symmetric padding so a long name never runs under it. MetadataDialog/MetadataActivator take optional size and density props for it; cards and the reader keep their defaults. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Amazing Spider-Man (1963) #1 / 3, the parenthesised year being the volume's). A subdued facts line under it carries the series run and status (1963–1996 · Completed, also1963–,–1996or1963) in the issue-title size. Nothing renders when both are unknown.The Amazing Spider-Man 1963–1996) from two new nullable title fields,collectionStartYear/collectionEndYear.MetadataDialog/MetadataActivatortake optionalsizeanddensityprops. The title usessmall+compact, a 20×20 button that fits the 24px bar. Cards and the reader are unchanged: still 48px, default size.formattedYearRange()incomic-name.jsis shared by the header and the title.Out of scope
Test results
make fix,make lint,make ty: clean.browser-toolbar-title.test.jscovers the title with and without years, a volume title, and the button: absent on root, and on a series page with the expected book.metadata-header.test.jshas the adapted range cases plus the facts line.tests/test_metadata_series_fields.pyadds a series title carrying the years and a volume title carrying none.Screenshots
Checked on an isolated dev stack (fresh DB, three seeded comics) at 1024px and 375px. Local files, to drag in here:
/Users/aj/Code/codex/.claude/worktrees/series-display-1358af/tasks/screenshots/1-comic-dialog-facts-line.jpg: a comic's dialog with the facts line/Users/aj/Code/codex/.claude/worktrees/series-display-1358af/tasks/screenshots/2-series-title-tags-button.jpg: the series page title with the Tags button/Users/aj/Code/codex/.claude/worktrees/series-display-1358af/tasks/screenshots/3-series-dialog-from-title.jpg: the series dialog opened from that button/Users/aj/Code/codex/.claude/worktrees/series-display-1358af/tasks/screenshots/4-series-title-mobile.png,5-comic-dialog-mobile.png: the same at 375px🤖 Generated with Claude Code