Repository navigation
Tag editor edits series end year, status and summary (database only) - #986
Merged
Merged
Conversation
No format codex writes can hold a series' end year, status or summary: MetronInfo has only StartYear and ComicInfo none of them, and only comicbox's own comicbox.json/yaml carries them, which codex won't embed in comics. So the tag editor saves these three straight to the Series row through a new admin endpoint, POST /admin/series-attrs, and says so under the inputs: they are saved in Codex only, not written to the comic files. Re-imports leave them standing, since the importer ignores a series attribute a file doesn't carry. The inputs seed from the series and no write format gates them. They lock, with the reason shown, unless exactly one series is being edited and its name is unchanged, because the values land on one Series row and a rename would leave them on the row the comics are moving off. Only changed attributes are sent; a clear sends null or "". A save with nothing else skips the preflight and the tag write, and on the browser route the page reloads so the title's series years refresh. The status choices derive from SeriesStatusChoices into series-statuses.json. NEWS also gains the line PR 983 lacked for the online tag match picker. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StartYearand ComicInfo has none of them. Only comicbox.json/yaml carries them, and that won't be embedded in comics. Start Year keeps writing to MetronInfo as before. Re-imports leave the database values standing, because the importer ignores a series attribute a file doesn't carry. A new importer test pins that down.POST /api/v4/admin/series-attrsis admin-only and takescollection+pkslike tag-write.""clears one. It bumpsupdated_at.SeriesStatusChoicesintoseries-statuses.json.Follow-ups (not here)
Test results
make fix,make lint,make ty: clean.edit-panel-series-attrs.test.js: seeding, no format gate, lock reasons, warning, changed-only and clear payloads, a database-only save skipping preflight and tag write, both requests, browser reload.tests/test_admin_series_attrs.py(set, series collection, partial, clear, two series, nothing sent, bad status, bad year, non-admin), a re-import test, and status-choice derivation tests./admin/series-attrswas posted, the row updated, the CBZ was untouched, and the title read 1963–1998 at once.Screenshots
Local files, to drag in here:
/Users/aj/Code/codex/.claude/worktrees/series-display-1358af/tasks/screenshots/6-editor-series-attrs.jpg: the editor with the new inputs and warning/Users/aj/Code/codex/.claude/worktrees/series-display-1358af/tasks/screenshots/7-editor-series-attrs-mobile.jpg: the same at 375px🤖 Generated with Claude Code