Skip to content

Reject jobs with missing parents before caching - #268

Merged
ajvb merged 1 commit into
ajvb:masterfrom
dajiaohuang:fix/reject-missing-parent-jobs
Nov 8, 2026
Merged

ajvb merged 1 commit into
ajvb:masterfrom
dajiaohuang:fix/reject-missing-parent-jobs

Conversation

@dajiaohuang

Copy link
Copy Markdown
Contributor

Summary

  • Validate all requested parent jobs before inserting a new job into the cache.
  • Prevent a rejected job with a nonexistent parent from remaining visible/persisted as an orphan.
  • Extend the existing parent-missing test to assert the job is absent after the error.

Validation

  • go test -mod=readonly ./job -run '^TestDependentJobsParentDoesNotExist$' -count=1 passed.
  • The full suite was not run: the repository CI starts Consul, MongoDB, and MySQL services, which are outside this task's synthetic/local-only test boundary. No service containers were started.
  • No CI or review status was queried.

@ajvb
ajvb merged commit 4bd3503 into ajvb:master Nov 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants