[baktun14]

Why

Closes CON-1192. Without this, someone could pay, collect the affiliate commission and then get a refund, and repeat it.

What

• A refund on a referred payment (applyRefund) and a lost dispute (new charge.dispute.closed handler, new dispute_lost_at column, migration 0129) queue the same SyncAffiliateCommission job. The job takes back the matching share of the commission: floor(commission * netPaid / amount) is kept, the rest is reversed, and the total reversed never exceeds the commission.
• The affiliate's balance is reduced by the difference and never goes below 0. Any shortfall is logged, and billing history shows the commission as partly or fully refunded. Tracks affiliate_commission_reversed.
• Reversals apply even when the flag is off or the affiliate is revoked. Only a settlement can grant commission. When a refund lands before the grant job runs, the grant pays the net amount in a single top-up.
• reduceWalletBalance now locks the wallet it reduces (the team's or the member's own), as topUpWallet does, so a reversal and a grant on the same wallet don't overwrite each other.
• The reversal debits the affiliate through main's refund debit, keyed by the commission row and its reversed totals, so a redelivered reversal never debits twice. The commission row is locked FOR NO KEY UPDATE, because that debit references it from another connection.
• The reversal comes out of the affiliate's personal organization, where the commission was filed. A commission whose affiliate account was deleted is left alone.
• No commission is paid to an affiliate whose wallet is abuse-locked.
• A lost dispute still leaves the payer's own balance alone, the same as today.

Ops before turning affiliate_program on: add charge.dispute.closed to the Stripe webhook endpoint's events.

Testing

Unit specs for partial and full refunds, a lost dispute, a won dispute, a repeated sync, a revoked affiliate, the flag off, a refund before the grant, the abuse lock and rounding. Integration specs through the real job worker. Functional webhook specs for a 40% refund (200 of 500 taken back) and a lost dispute (fully reversed, payer untouched). Mutation score on changed lines: 100%.

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

_{Tip: disable this comment in your organization's Code Review settings.}

[coderabbitai]

Warning

Review limit reached

• Run on-demand review

_{This review includes 24 billable files and costs up to $6.00.}

• Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 10 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: akash-network/console
• Branch: main
• File: .coderabbit.yaml
• Commit: c9ad6ac
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Essentials
• Run ID: 4046fa60-28dd-4e04-a4fb-7206d601a788

Commits

Reviewing files that changed from the base of the PR and between c9ad6ac and 0950fbf.

Files selected for processing: 24

• apps/api/drizzle/0129_dispute_lost_at.sql
• apps/api/drizzle/meta/0129_snapshot.json
• apps/api/drizzle/meta/_journal.json
• apps/api/src/affiliate/services/affiliate-commission/affiliate-commission.service.integration.ts
• apps/api/src/affiliate/services/affiliate-commission/affiliate-commission.service.spec.ts
• apps/api/src/affiliate/services/affiliate-commission/affiliate-commission.service.ts
• apps/api/src/affiliate/services/affiliate-commission/sync-affiliate-commission.handler.integration.ts
• apps/api/src/affiliate/services/affiliate-commission/sync-affiliate-commission.handler.spec.ts
• apps/api/src/affiliate/services/affiliate-commission/sync-affiliate-commission.handler.ts
• apps/api/src/affiliate/services/affiliate-commission/sync-affiliate-commission.job.ts
• apps/api/src/billing/model-schemas/stripe-transaction/stripe-transaction.schema.ts
• apps/api/src/billing/repositories/stripe-transaction/stripe-transaction.repository.integration.ts
• apps/api/src/billing/repositories/stripe-transaction/stripe-transaction.repository.ts
• apps/api/src/billing/services/refill/refill.service.spec.ts
• apps/api/src/billing/services/refill/refill.service.ts
• apps/api/src/billing/services/refund-debit/refund-debit.service.integration.ts
• apps/api/src/billing/services/stripe-transaction/stripe-transaction.service.integration.ts
• apps/api/src/billing/services/stripe-transaction/stripe-transaction.service.spec.ts
• apps/api/src/billing/services/stripe-transaction/stripe-transaction.service.ts
• apps/api/src/billing/services/stripe-webhook/stripe-webhook.service.spec.ts
• apps/api/src/billing/services/stripe-webhook/stripe-webhook.service.ts
• apps/api/src/core/services/analytics/analytics.service.ts
• apps/api/test/functional/stripe-webhook.spec.ts
• apps/api/test/seeders/database-stripe-transaction.seeder.ts

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

[baktun14]

@claude review

[claude]

⚠️ Code review skipped — your organization's remaining monthly code review budget is too low to start another review, so this review was not started.

An organization admin can view or raise the monthly spending cap at claude.ai/admin-settings/usage, on the Claude Code Review row under Services. The cap resets at the start of the next billing period.

Once the cap resets or is raised, someone with write access to this repository can comment @claude review on this pull request to trigger a review.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.13%. Comparing base (c9ad6ac) to head (0950fbf).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4280      +/-   ##
==========================================
+ Coverage   94.93%   95.13%   +0.19%     
==========================================
  Files        2155     2048     -107     
  Lines       62826    60091    -2735     
  Branches    15726    15189     -537     
==========================================
- Hits        59646    57167    -2479     
+ Misses       2860     2620     -240     
+ Partials      320      304      -16     

Flag	Coverage Δ		*Carryforward flag
api	96.87% <100.00%> (+0.01%)	⬆️
deploy-web	93.63% <ø> (ø)		Carriedforward from c9ad6ac
log-collector	?
notifications	96.68% <ø> (ø)		Carriedforward from c9ad6ac
provider-console	81.68% <ø> (ø)		Carriedforward from c9ad6ac
provider-inventory	?
provider-proxy	95.18% <ø> (ø)		Carriedforward from c9ad6ac
tx-signer	?

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines	Coverage Δ
...filiate-commission/affiliate-commission.service.ts	100.00% <100.00%> (ø)
...te-commission/sync-affiliate-commission.handler.ts	100.00% <100.00%> (ø)
...iliate-commission/sync-affiliate-commission.job.ts	100.00% <100.00%> (ø)
...as/stripe-transaction/stripe-transaction.schema.ts	66.66% <ø> (ø)
...tripe-transaction/stripe-transaction.repository.ts	89.32% <100.00%> (+0.21%)	⬆️
.../api/src/billing/services/refill/refill.service.ts	98.92% <100.00%> (+0.10%)	⬆️
...s/stripe-transaction/stripe-transaction.service.ts	95.87% <100.00%> (+0.20%)	⬆️
.../services/stripe-webhook/stripe-webhook.service.ts	100.00% <100.00%> (ø)
...i/src/core/services/analytics/analytics.service.ts	100.00% <ø> (ø)

... and 111 files with indirect coverage changes

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.