Repository navigation
Fix Portfolio Optimizer failing on mixed datetime resolutions between prices and FX closes - #248
Merged
Merged
Conversation
… prices and FX closes fx_levels_on() passed merge_asof a us-resolution date key and a ms-resolution FX index (Parquet-read closes vs dates parsed from stored strings under pandas 3), which pandas rejects as incompatible merge keys. The FX index is now aligned to the dates' resolution before the merge, without mutating the cached FX series.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MergeError: incompatible merge keys [0] dtype('<M8[us]') and dtype('<M8[ms]')raised fromfx_conversion_helpers.fx_levels_on().datetime64[us], while the FX closes read back from Parquet aredatetime64[ms];merge_asofrequires identical key dtypes.Test plan
pytest tests/test_fx_conversion_helpers.py tests/test_portfolio_optimizer_engine.py tests/test_fx_drag_engine.py tests/test_accounts_engine.py tests/test_strategy_backtest_engine.py tests/test_strategy_backtest_runs.pyreturns_in_basecase with string-parsed dates against millisecond FX