fix(cli): hydrate acquired deployment configuration - #380
Open
alongubkin wants to merge 2 commits into
Open
Conversation
Greptile SummaryThe PR hydrates the CLI deployment configuration from the manager’s acquisition payload and makes target-release resolution fail closed.
Confidence Score: 5/5The PR appears safe to merge because no eligible blocking failure remains in the follow-up review scope. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| crates/alien-cli/src/commands/deploy.rs | Hydrates configuration from acquisition, validates target-release stacks, and restores runtime-only manager credentials before running the deployment loop. |
Sequence Diagram
sequenceDiagram
participant CLI as alien CLI
participant Manager as Deployment Manager
participant Runner as Deployment Runner
CLI->>Manager: Fetch deployment and target release
Manager-->>CLI: Deployment state and release stack
CLI->>Manager: Acquire deployment session
Manager-->>CLI: Acquired deploymentConfig
CLI->>CLI: Hydrate config and restore runtime fields
CLI->>Runner: Run deployment step loop
Runner->>Manager: Reconcile final state
CLI->>Manager: Release deployment session
Reviews (2): Last reviewed commit: "chore: refresh generated TypeScript APIs" | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploymentConfigreturned by acquisition before entering the deploy loopWhy
The CLI previously rebuilt configuration from local arguments after acquiring a deployment and silently ignored target-release lookup failures. A setup-owned deployment could therefore enter reconciliation without its desired resource graph and complete an observe-only pass instead of applying the release.
The generated refresh is included because the required
pnpm generateclean-tree gate changed the pinned outputs independently of the Rust diff.Verification
cargo fmt --check -p alien-clicargo test -p alien-cli commands::deploy::tests::target_release_requires_a_stack_for_the_deployment_platformcargo test -p alien-cli commands::deploy::tests::deployment_models_match_platform_deliverypnpm generategit diff --ignore-all-space --exit-code -- packages/core packages/sdk