test(sandbox): exercise a sandbox session end to end - #403
Open
ItamarZand88 wants to merge 1 commit into
Open
Conversation
Greptile SummaryThe PR adds end-to-end sandbox coverage to the comprehensive Rust and TypeScript test applications.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported false-success cleanup path now runs termination after the exercise and propagates cleanup failure.
|
| Filename | Overview |
|---|---|
| tests/e2e/test-apps/comprehensive-rust/src/handlers/sandbox.rs | Adds a complete Rust sandbox exercise and now propagates cleanup or termination-confirmation failures. |
| tests/e2e/test-apps/comprehensive-typescript/src/handlers/sandbox.ts | Adds the equivalent TypeScript sandbox exercise while ensuring cleanup runs even when functional checks fail. |
| crates/alien-test/tests/common/bindings.rs | Adds the runner-side sandbox endpoint check and validates the successful binding response. |
| crates/alien-test/src/e2e.rs | Registers sandbox as a supported binding for the Local deployment model. |
Sequence Diagram
sequenceDiagram
participant Runner as E2E runner
participant App as Comprehensive test app
participant Sandbox as Sandbox binding
Runner->>App: POST /sandbox-test/alien-sandbox
App->>Sandbox: create session
App->>Sandbox: run command
Sandbox-->>App: stdout and exit frame
App->>Sandbox: write file
App->>Sandbox: read file
Sandbox-->>App: matching bytes
App->>Sandbox: terminate session
App->>Sandbox: get session
Sandbox-->>App: absent or terminated
App-->>Runner: success
Reviews (6): Last reviewed commit: "test(sandbox): exercise a sandbox sessio..." | Re-trigger Greptile
ItamarZand88
force-pushed
the
itamar/alien-75-sandbox-6-typescript
branch
from
August 11, 2026 21:22
1b99225 to
b89ff3c
Compare
ItamarZand88
force-pushed
the
itamar/alien-75-sandbox-7-e2e
branch
2 times, most recently
from
August 11, 2026 21:26
2cbe0ec to
4a813ec
Compare
ItamarZand88
force-pushed
the
itamar/alien-75-sandbox-6-typescript
branch
from
August 11, 2026 21:26
b89ff3c to
52bc095
Compare
ItamarZand88
force-pushed
the
itamar/alien-75-sandbox-7-e2e
branch
from
August 11, 2026 22:16
4a813ec to
9e50cc3
Compare
ItamarZand88
force-pushed
the
itamar/alien-75-sandbox-6-typescript
branch
from
August 11, 2026 22:16
52bc095 to
28faa2f
Compare
ItamarZand88
force-pushed
the
itamar/alien-75-sandbox-7-e2e
branch
from
August 11, 2026 22:24
9e50cc3 to
d835538
Compare
ItamarZand88
force-pushed
the
itamar/alien-75-sandbox-6-typescript
branch
from
August 11, 2026 22:24
28faa2f to
57c6f58
Compare
greptile-apps
Bot
dismissed
their stale review
August 11, 2026 22:24
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exercises a sandbox end to end: the test app declares one, and the suite drives a real session through it rather than asserting on rendered templates.
What the test does when it runs:
What I did
The assertions are on observed behaviour, not on artifacts. A test that checks a template contains a string would pass against a sandbox that never starts, so this one runs code inside the session and reads back what it wrote.
Files touched
crates/alien-test/— the sandbox case in the deployment suite.tests/e2e/test-apps/comprehensive-typescript/— the declaration and the handler the test drives.How I tested
The suite itself is the test: it creates a session, runs a command, round-trips a file and
terminates, asserting on what came back rather than on rendered artifacts.
I have not run it against a live deployment in this change — it needs cloud credentials and a
free slot. It should be run before merge, and the thing to watch is teardown: an accepted delete
is not a completed one, so confirm the session is actually gone rather than trusting the call.