fix: block bare-zero cost and undeclared preview failures at candidate finalization - #205
Open
ruanzhengxin-zhuxing wants to merge 1 commit into
Open
fix: block bare-zero cost and undeclared preview failures at candidate finalization#205ruanzhengxin-zhuxing wants to merge 1 commit into
ruanzhengxin-zhuxing wants to merge 1 commit into
Conversation
…e finalization The OSS+CDN candidate in session 62a1cae4 finished cost_estimating with preview_validation.succeeded=false (missing CdnDomainName) and a misleading ¥0/月 monthly estimate, then entered user selection as a comparable option. - complete_step: add when_conclusion_field_matches regex predicate and forbid_completion guard action with two new message keys - selling pipeline: cost_estimating now rejects bare-zero monthly_estimate and requires missing_deployment_parameters/error when preview validation fails (PreviewStack stays a soft gate) - iac-aliyun-cost skill/prompt: pay-as-you-go resources must report a usage-based range estimate or "询价失败", never bare ¥0/月 - confirm_and_select prompt: surface preview/cost warnings in candidate summaries and forbid presenting ¥0/月 as a definite monthly cost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
Session
62a1cae4e5524c1492d28c152809e8a0中，OSS+CDN 候选在preview_validation.succeeded=false（CdnDomainName 缺失）的情况下仍以 ¥0/月 的月成本定稿完成并进入用户选择，与 ECS+SLB 候选形成误导性成本对比。改动
when_conclusion_field_matches正则谓词与forbid_completion动作，及两个 message key（零成本禁止 / preview 失败须声明缺口）cost_estimating新增 completion_guards——裸零金额monthly_estimate拒绝定稿；preview_validation.succeeded=false时必须提供missing_deployment_parameters或error（PreviewStack 保持软门禁，不误杀外部输入缺失场景）total_monthly_cost不得展示 ¥0/月 伪确定值测试
TestCostEstimatingGuards（引擎层 18 例）与tests/pipeline/selling/test_cost_estimating_guards.py（配置/正则 17 例）make lint通过；全量 pytest 13305 passed（2 项 pre-existing 环境相关失败与本改动无关）Harness WorkItem: bbd3e2d8-028d-409f-b9d7-ca6d688fa480